After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646473 - Port mini-commander applet to GTK3
Port mini-commander applet to GTK3
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: mini-commander
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-04-01 19:47 UTC by Christopher Aillon
Modified: 2011-05-04 19:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace GDK_<keyname> with GDK_KEY_<keyname> (4.64 KB, patch)
2011-04-01 19:49 UTC, Christopher Aillon 		none Details | Review
Do not use gtk_dialog_set_has_separator (1.03 KB, patch)
2011-04-01 19:49 UTC, Christopher Aillon 		none Details | Review
Use g_spawn_async instead of gdk_spawn_on_screen (2.02 KB, patch)
2011-04-01 19:50 UTC, Christopher Aillon 		none Details | Review
Access the editable widget via gtk_cell_area_get_edit_widget (1.77 KB, patch)
2011-04-01 19:50 UTC, Christopher Aillon 		none Details | Review
use accessor functions instead of direct access (3.75 KB, patch)
2011-04-01 19:51 UTC, Christopher Aillon 		none Details | Review
Also consider to use the new common path for menu files (413 bytes, patch)
2011-04-22 11:05 UTC, Enrico Minack 		none Details | Review

Description Christopher Aillon 2011-04-01 19:47:27 UTC 
Patches coming up...
Comment 1 Christopher Aillon 2011-04-01 19:49:10 UTC 
Created attachment 184892 [details] [review]
Replace GDK_<keyname> with GDK_KEY_<keyname>
Comment 2 Christopher Aillon 2011-04-01 19:49:40 UTC 
Created attachment 184893 [details] [review]
Do not use gtk_dialog_set_has_separator
Comment 3 Christopher Aillon 2011-04-01 19:50:05 UTC 
Created attachment 184894 [details] [review]
Use g_spawn_async instead of gdk_spawn_on_screen
Comment 4 Christopher Aillon 2011-04-01 19:50:33 UTC 
Created attachment 184895 [details] [review]
Access the editable widget via gtk_cell_area_get_edit_widget
Comment 5 Christopher Aillon 2011-04-01 19:51:03 UTC 
Created attachment 184896 [details] [review]
use accessor functions instead of direct access
Comment 6 Enrico Minack 2011-04-18 19:50:25 UTC 
I can confirm that these patches make the mini commander build again. It can also be started, but since I am not familiar with its usage, I cannot tell if it is working properly. But we can only tell when we can build it. So this should go into master.
Comment 7 Christopher Aillon 2011-04-19 06:18:47 UTC 
Should I go ahead and push these then?
Comment 8 Enrico Minack 2011-04-22 11:05:57 UTC 
Created attachment 186473 [details] [review]
Also consider to use the new common path for menu files

Menu xml files are now placed under a different path.
Comment 9 Enrico Minack 2011-04-27 20:17:16 UTC 
Christopher, since nobody raised objections, please go for it and commit these patches to git master. Then they can make it into the next 3.1.1 unstable release on May 9th.