After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646225 - need translation context
need translation context
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-30 12:27 UTC by Pavol Klačanský
Modified: 2012-08-07 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix the issue (1.35 KB, patch)
2011-08-26 13:26 UTC, José Aliste
committed Details | Review

Description Pavol Klačanský 2011-03-30 12:27:17 UTC
what is embedded?

#: ../backend/pdf/ev-poppler.cc:1028
msgid "Embedded"

#: ../backend/pdf/ev-poppler.cc:1030
msgid "Not embedded"
msgstr "Nie je zabudovaná"
Comment 1 Pavol Klačanský 2011-03-30 12:39:00 UTC
need plural forms

#, c-format
msgid ""
"There are %d print jobs active. Wait until print finishes before closing?"
Comment 2 José Aliste 2011-03-30 12:49:25 UTC
(In reply to comment #0)
> what is embedded?
> 
> #: ../backend/pdf/ev-poppler.cc:1028
> msgid "Embedded"
> 
> #: ../backend/pdf/ev-poppler.cc:1030
> msgid "Not embedded"
> msgstr "Nie je zabudovaná"

Both of these are strings are used in the Font Info Description. They refer to whether a font is embedded in the document or not.
Comment 3 José Aliste 2011-03-30 12:51:25 UTC
(In reply to comment #1)
> need plural forms
> 
> #, c-format
> msgid ""
> "There are %d print jobs active. Wait until print finishes before closing?"

Right, but we are on string freeze.. and this message is not shown enough to request a freeze break in my opinion. I'll add singular and plural versions after Gnome 3.0 is released. 

Carlos, what do you think?
Comment 4 Pavol Klačanský 2011-03-30 15:22:11 UTC
also this one

"Not found"
Comment 5 Pavol Klačanský 2011-03-30 15:22:14 UTC
also this one

"Not found"
Comment 6 Pavol Klačanský 2011-03-30 15:22:39 UTC
sorry for double post
Comment 7 F Wolff 2011-08-24 20:26:45 UTC
String freeze is in less than two weeks. It would be great if these issues can be fixed soon, especially the plural string that was postponed because of the previous string freeze. For the others, comments can be added at any time to the code, but the earlier the better, of course :-)
Comment 8 José Aliste 2011-08-25 17:17:35 UTC
(In reply to comment #7)
> String freeze is in less than two weeks. It would be great if these issues can
> be fixed soon, especially the plural string that was postponed because of the
> previous string freeze. For the others, comments can be added at any time to
> the code, but the earlier the better, of course :-)

In fact, my answer in comment #3 is wrong. Actually the message is in plural form. Another different message is shown for singular form, so no need to change anything.
Comment 9 F Wolff 2011-08-26 08:25:32 UTC
I assume you are referring to 3 lines above that string. We definitely need plurals even if you are going to do something different for the case of a single print job. Please see:
https://live.gnome.org/TranslationProject/DevGuidelines/Plurals

The strings about "embedded" and "not found" still don't have any comments in the code for the translators. Is it possible to add that now as well? Thanks!
Comment 10 José Aliste 2011-08-26 10:09:51 UTC
Thanks for the pointer. While I now understand why it is needed to add a ngettext, I don't like too much to have a new string (for the singular form) that won't be displayed. is there a solution for that?
Comment 11 F Wolff 2011-08-26 11:23:16 UTC
Not that I can really think of, but the waste is really minimal. With gettext we already save on not having separate string IDs in the normal case, so see this as a string ID :-)

Maybe in future somebody might want that string for some purpose anyway, and it will be in place.
Comment 12 José Aliste 2011-08-26 13:26:07 UTC
Created attachment 194831 [details] [review]
fix the issue

Here is the patch that uses ngettext instead of _( to get correct plural forms. 

Carlos, is it Ok to push?
Comment 13 Carlos Garcia Campos 2011-08-28 09:43:06 UTC
Review of attachment 194831 [details] [review]:

Thanks!
Comment 14 F Wolff 2012-07-12 12:56:22 UTC
Ping? Patch available, or has this already been committed?
Comment 15 Carlos Garcia Campos 2012-08-07 17:06:09 UTC
Yes, this was already committed. Closing the bug.