After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646220 - dconf-editor crashes on empty schema description
dconf-editor crashes on empty schema description
Status: RESOLVED FIXED
Product: dconf-editor
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: dconf-editor maintainer(s)
dconf-editor maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-03-30 11:28 UTC by Fabian Deutsch
Modified: 2015-02-22 12:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes this crash. (1.01 KB, patch)
2011-03-30 11:28 UTC, Fabian Deutsch 		reviewed Details | Review

Description Fabian Deutsch 2011-03-30 11:28:03 UTC 
Created attachment 184683 [details] [review]
Fixes this crash.

In a case like this (caribou schema):

    <key type="b" name="default-colors">
      <default>true</default>
      <summary>Use the default theme colors</summary>
      <description/>
    </key>

the editor crashes currently. The attched patch fixes this.
Comment 1 Nils Philippsen 2011-04-06 13:04:35 UTC 
I can confirm that the attached patch fixes the problem of dconf-editor crashing on startup with schemata such as the one described in comment #0.
Comment 2 Matthias Clasen 2011-04-06 18:56:55 UTC 
Review of attachment 184683 [details] [review]:

::: editor/dconf-schema.vala
@@ +55,3 @@
                 summary = child->children->content;
             else if (child->name == "description")
+                description = child->children == null ? "" : child->children->content;

Doesn't make sense to me to fix this here without fixing the same issue for summary two lines up.
Comment 3 Allison Karlitskaya (desrt) 2011-05-08 16:27:22 UTC 
Matthias: it would have been helpful if you forwarded the Fedora vendor patch upstream on this one... I only know of it existing due to a remark you made on IRC (a month later).

In any case, I found it and pushed it upstream now.  Thanks for the fix.


commit b568b12ccecb114ff6d910f1d22309ad1c83273c
Author: Matthias Clasen <mclasen@redhat.com>
Date:   Sun May 8 18:23:11 2011 +0200

    editor: Don't crash on empty schema descriptions
    
    Based on a patch from Fabian Deutsch <fabian.deutsch@gmx.de>
Comment 4 André Klapper 2015-02-22 12:23:22 UTC 
[moving dconf>editor tickets to dconf-editor product. See bug 744791]