After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646205 - assignment to undeclared variable format in telepathyClient.js
assignment to undeclared variable format in telepathyClient.js
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: GnomeShell301
 
 
Reported: 2011-03-30 08:02 UTC by Guillaume Desmottes
Modified: 2011-04-08 18:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
telepathyClient: Fix JS warning triggered by undecalered variable (925 bytes, patch)
2011-03-30 09:45 UTC, drago01 		accepted-commit_after_freeze Details | Review
telepathyClient: Fix JS warning triggered by undeclared variable (919 bytes, patch)
2011-03-31 19:50 UTC, drago01 		committed Details | Review

Description Guillaume Desmottes 2011-03-30 08:02:55 UTC 
I noticed this error:

    JS ERROR: !!!   WARNING: 'assignment to undeclared variable format'
    JS ERROR: !!!   WARNING: file '/home/cassidy/usr/share/gnome-shell/js/ui/telepathyClient.js' line 482 exception 0 number 156


and indeed, this variable doesn't seem to be declared.
Comment 1 drago01 2011-03-30 09:45:12 UTC 
Created attachment 184676 [details] [review]
telepathyClient: Fix JS warning triggered by undecalered variable
Comment 2 Dan Winship 2011-03-30 16:57:09 UTC 
Comment on attachment 184676 [details] [review]
telepathyClient: Fix JS warning triggered by undecalered variable

>+        let format = "";

just "let format;" is fine; it's guaranteed to be assigned a value before it gets used.
Comment 3 Dan Winship 2011-03-30 16:57:29 UTC 
also, typo in commit message "decalered"
Comment 4 drago01 2011-03-31 19:50:10 UTC 
Created attachment 184814 [details] [review]
telepathyClient: Fix JS warning triggered by undeclared variable
Comment 5 Guillaume Desmottes 2011-04-05 10:49:01 UTC 
3.0.0 has been released; can we merge this fix now?
Comment 6 Florian Müllner 2011-04-05 10:50:50 UTC 
Not yet - 3.0 has been released, but the code is still frozen as it hasn't been branched yet.
Comment 7 Guillaume Desmottes 2011-04-05 11:13:50 UTC 
No, the hard code freeze ends with the 3.0.0 release. See https://live.gnome.org/TwoPointNinetyone#Schedule
Comment 8 Florian Müllner 2011-04-05 11:54:05 UTC 
Quoting topic of #gnome-shell Owen set right after releasing 3.0:
"GNOME Shell and Mutter now code-frozen until we branch."

So the freeze is still in place for gnome-shell/mutter.
Comment 9 Owen Taylor 2011-04-05 16:05:50 UTC 
(In reply to comment #7)
> No, the hard code freeze ends with the 3.0.0 release. See
> https://live.gnome.org/TwoPointNinetyone#Schedule

Making a 3.0.1 that's better than 3.0.0 and doesn't end up with regressions will require care. I'll send out a mail later today with an idea for a schedule from getting from here to 3.0.1. But certainly we're completely frozen until GNOME 3.0 goes out tomorrow, to deal with the possibility of a 3.0.0.1.
Comment 10 Florian Müllner 2011-04-08 14:17:52 UTC 
(In reply to comment #5)
> 3.0.0 has been released; can we merge this fix now?

GNOME 3.0 has been released and the patch on the 3.0.1 blocker list - so good to go now.
Comment 11 drago01 2011-04-08 18:33:09 UTC 
Attachment 184814 [details] pushed as 57a332b - telepathyClient: Fix JS warning triggered by undeclared variable