After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646201 - Use the custom main context in SoupProxyResolverDefault
Use the custom main context in SoupProxyResolverDefault
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
unspecified
Other All
: Normal blocker
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2011-03-30 07:49 UTC by Sebastian Dröge (slomo)
Modified: 2011-03-30 15:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use the custom main context in SoupProxyResolverDefault (1.12 KB, patch)
2011-03-30 07:49 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2011-03-30 07:49:43 UTC 
Hi,
currently the default proxy resolver always uses the default main
context. This causes interesting assertions and crashes when using
a non-default main context for the async soup session because
the non-default main context will be acquired from the main thread,
which does not own it. Or even worse, if no main loop is running on
the default main context nothing will ever happen.

Attached patch fixes this.
Comment 1 Sebastian Dröge (slomo) 2011-03-30 07:49:45 UTC 
Created attachment 184667 [details] [review]
Use the custom main context in SoupProxyResolverDefault
Comment 2 Dan Winship 2011-03-30 14:08:20 UTC 
Comment on attachment 184667 [details] [review]
Use the custom main context in SoupProxyResolverDefault

oops. I'll send mail to release-team...
Comment 3 Sebastian Dröge (slomo) 2011-03-30 14:22:21 UTC 
Maybe I should add that this causes problems for GStreamer's HTTP source plugin, which is using a non-default main context and a main loop that runs not in the main thread.
Comment 4 Dan Winship 2011-03-30 14:55:38 UTC 
Comment on attachment 184667 [details] [review]
Use the custom main context in SoupProxyResolverDefault

ok'ed by release-team. http://mail.gnome.org/archives/release-team/2011-March/msg00597.html
Comment 5 Sebastian Dröge (slomo) 2011-03-30 15:11:37 UTC 
commit 87e7ae14487fde5144d16963c4a73612acf0aca5
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Wed Mar 30 09:41:33 2011 +0200

    Use the custom main context in SoupProxyResolverDefault
    
    https://bugzilla.gnome.org/show_bug.cgi?id=646201