Bug 646197 – Crash with VALARM without ACTION property

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 646197 - Crash with VALARM without ACTION property


Summary:	Crash with VALARM without ACTION property


Status:	RESOLVED FIXED

Product:	evolution
Classification:	Applications
Component:	Plugins
Version:	2.32.x (obsolete)
Hardware:	Other Linux

Importance:	Normal critical
Target Milestone:	---
Assigned To:	evolution-plugin-maintainers
QA Contact:	Evolution QA team

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2011-03-30 06:37 UTC by Milan Crha
Modified:	2011-04-18 14:36 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
evo patch (673 bytes, patch) 2011-03-30 06:53 UTC, Milan Crha	committed	Details \| Review

Description Milan Crha 2011-03-30 06:37:40 UTC

Moving this from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=691839

abrt version: 1.1.17
architecture: i686
Attached file: backtrace, 45471 bytes
cmdline: evolution
component: evolution
Attached file: coredump, 116477952 bytes
crash_function: icalvalue_get_action
executable: /usr/bin/evolution
kernel: 2.6.35.11-83.fc14.i686
package: evolution-2.32.2-1.fc14
rating: 4
reason: Process /usr/bin/evolution was killed by signal 11 (SIGSEGV)
release: Fedora release 14 (Laughlin)
time: 1301411631
uid: 500

How to reproduce
-----
1. It crashes when ever trying to open new calendar scheduled events.

+ Trace 226506

Thread 1 (Thread 0xb789c880 (LWP 2750))

#0 icalvalue_get_action
at icalderivedvalue.c line 699
#1 icalproperty_get_action
at icalderivedproperty.c line 307
#2 extract_itip_data
at itip-formatter.c line 1759
#3 format_itip_object
at itip-formatter.c line 2201
#4 efh_object_requested
at em-format-html.c line 1560
#5 html_g_cclosure_marshal_BOOLEAN__OBJECT
at htmlmarshal.c line 81
#6 g_closure_invoke
at gclosure.c line 766
#7 signal_emit_unlocked_R
at gsignal.c line 3252
#8 g_signal_emit_valist
at gsignal.c line 2993
#9 g_signal_emit
at gsignal.c line 3040
#10 html_engine_object_requested_cb
at gtkhtml.c line 549
#11 html_g_cclosure_marshal_BOOLEAN__OBJECT
at htmlmarshal.c line 81
#12 g_closure_invoke
at gclosure.c line 766
#13 signal_emit_unlocked_R
at gsignal.c line 3252
#14 g_signal_emit_valist
at gsignal.c line 2993
#15 g_signal_emit
at gsignal.c line 3040
#16 element_parse_object
at htmlengine.c line 1635
#17 parse_one_token
at htmlengine.c line 3993
#18 new_parse_body
at htmlengine.c line 1432
#19 html_engine_timer_event
at htmlengine.c line 4965
#20 html_engine_flush
at htmlengine.c line 6956
#21 gtk_html_flush
at gtkhtml.c line 6410
#22 html_stream_sync_flush
at em-html-stream.c line 108
#23 sync_stream_process_message
at em-sync-stream.c line 87
#24 g_idle_dispatch
at gmain.c line 4254
#25 g_main_dispatch
at gmain.c line 2149
#26 g_main_context_dispatch
at gmain.c line 2702
#27 g_main_context_iterate
at gmain.c line 2780
#28 g_main_loop_run
at gmain.c line 2988
#29 IA__gtk_main
at gtkmain.c line 1237
#30 main
at main.c line 679

Comment 1 Milan Crha 2011-03-30 06:53:03 UTC

Created attachment 184661 [details] [review]
evo patch

for evolution;

The attached meeting invitation had an alarm, which had missing ACTION property, which lead to this crash. This patch discards alarms without ACTION property. Please note that the ACTION property is mandatory for the VALARM component.

Comment 2 André Klapper 2011-04-15 09:10:47 UTC

Milan: Patch has status "accepted-commit_after_freeze". Assuming this refers to 3.0 Hardcode Freeze, can this get a commit now?

Comment 3 Milan Crha 2011-04-18 14:35:46 UTC

Sure, it was waiting just on me.

Created commit dddda73 in evo master (3.1.1+)
Created commit f735a08 in evo gnome-3.0 (3.0.1+)