After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646194 - Unneeded vertical line in combobox living in toolbar
Unneeded vertical line in combobox living in toolbar
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-30 05:58 UTC by Vincent Untz
Modified: 2011-03-30 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (18.03 KB, image/png)
2011-03-30 05:58 UTC, Vincent Untz 		  Details
adwaita: force no separator for GtkComboboxes in primary toolbars (1.06 KB, patch)
2011-03-30 15:46 UTC, Cosimo Cecchi 		none Details | Review
Better patch, which fixes the problem in a more generic way. (1.35 KB, patch)
2011-03-30 16:13 UTC, Cosimo Cecchi 		committed Details | Review

Description Vincent Untz 2011-03-30 05:58:31 UTC 
Created attachment 184653 [details]
Screenshot

Start evince with a document, and look at the combobox in the toolbar. When it's not highlighted, there's a vertical line to separate the text from the arrow (see screenshot). This doesn't appear in any other comboboxes anywhere else..
Comment 1 Cosimo Cecchi 2011-03-30 15:46:13 UTC 
Created attachment 184704 [details] [review]
adwaita: force no separator for GtkComboboxes in primary toolbars

The separator-width is zero globally, except for the primary toolbars,
which show separators of 1px width; so we need to special-case a
combobox inside it.
Comment 2 Cosimo Cecchi 2011-03-30 16:13:36 UTC 
Created attachment 184707 [details] [review]
Better patch, which fixes the problem in a more generic way.

adwaita: don't propagate an 1px separator width to the whole toolbar

Instead, set a match rule on GtkSeparatorToolItem, which is what we
actuallly want to theme.

This fixes e.g. GtkComboboxes showing separators when on primary
toolbars, as described in