After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646183 - region: make the layout options modal
region: make the layout options modal
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-30 05:04 UTC by Cosimo Cecchi
Modified: 2011-03-30 20:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: make the layout options modal (972 bytes, patch)
2011-03-30 05:04 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-03-30 05:04:14 UTC 
I think the layout options dialog should be modal, as it operates only on the selected layout. It's also consistent with similar behavior of the other panels.
Comment 1 Cosimo Cecchi 2011-03-30 05:04:16 UTC 
Created attachment 184651 [details] [review]
region: make the layout options modal
Comment 2 Bastien Nocera 2011-03-30 09:20:33 UTC 
Comment on attachment 184651 [details] [review]
region: make the layout options modal

Looks good.
Comment 3 Cosimo Cecchi 2011-03-30 14:37:21 UTC 
Pushed to master after approval from r-t.

Attachment 184651 [details] pushed as eac562b - region: make the layout options modal
Comment 4 Sergey V. Udaltsov 2011-03-30 20:37:23 UTC 
Just one comment to Cosimo: options operate on ALL layouts. They do not depend on the selected layout.