After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646169 - Atomix GtkObjectRemove
Atomix GtkObjectRemove
Status: RESOLVED DUPLICATE of bug 742827
Product: atomix
Classification: Other
Component: atomix
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Atomix Maintainer(s)
Atomix Maintainer(s)
Depends on:
Blocks: 630874
 
 
Reported: 2011-03-29 22:45 UTC by Alexandru Burghelea
Modified: 2015-01-13 01:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
removal of GtkObject (2.52 KB, patch)
2011-03-29 22:49 UTC, Alexandru Burghelea
none Details | Review
making use of GObjectClass dispose (2.43 KB, patch)
2011-04-03 11:15 UTC, Alexandru Burghelea
none Details | Review

Description Alexandru Burghelea 2011-03-29 22:45:41 UTC
GtkObject is gone in Gtk3
Comment 1 Alexandru Burghelea 2011-03-29 22:49:58 UTC
Created attachment 184638 [details] [review]
removal of GtkObject

hi, i am proposing a path for this Goal.

i am waiting for reviews
Comment 2 Javier Jardón (IRC: jjardon) 2011-03-29 23:40:52 UTC
Hello Alex,

thanks for the patch. 

This patch can only be applied if atomix depends on GTK+3, and unfortunately is not the case. (there is not gtk_widget_destroy() in GTK+2, for example).
Anyway, you can make the code conditional with GTK_CHECK_VERSION(), but I'm not very sure if there is something working on port atomix to GTK+3 (maybe you? ;))
Comment 3 Alexandru Burghelea 2011-03-30 01:59:50 UTC
Thank's for the idea  with GTK_CHECK_VERSION(). In 2-3 days , i will submit a patch with it . As for porting atomix to GTK+3 I would really like to do that, the problem is that i have little time right now, but i will propose it as a project for a open-source development course held in my university.
Comment 4 Christian Persch 2011-03-30 09:49:50 UTC
Instead of GtkWidgetClass::destroy (gtk3 only) you could use GObjectClass::dispose (which is better anyway :).
Comment 5 Alexandru Burghelea 2011-04-03 11:15:31 UTC
Created attachment 185018 [details] [review]
making use of GObjectClass dispose

hi, here is the other version I promised.
Hope it's better
Comment 6 Alan Horkan 2011-05-16 01:41:27 UTC
If someone is applying Atomix patches it would be great if you could also check bugzilla bug 313130 and see if the patch there can be applied too. 

https://bugzilla.gnome.org/show_bug.cgi?id=313130
Comment 7 Robert Roth 2015-01-13 01:17:22 UTC
Based on the comments this would be fixed by a GTK3 port, so marking this as a duplicate of the GTK3 port bug.

Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 742827 ***