After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 646140 - Ad-hoc icon should be symbolic
Ad-hoc icon should be symbolic
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-29 17:23 UTC by Cosimo Cecchi
Modified: 2011-03-29 18:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screenshot (5.92 KB, image/png)
2011-03-29 17:23 UTC, Cosimo Cecchi
  Details
network: use symbolic icon for ad-hoc wireless connections (974 bytes, patch)
2011-03-29 18:25 UTC, Cosimo Cecchi
committed Details | Review
Additional patch, which closes the gap between the signal and mode if no security icon is dipslayed. (1.42 KB, patch)
2011-03-29 18:35 UTC, Cosimo Cecchi
committed Details | Review
screenshot after patch (9.03 KB, image/png)
2011-03-29 18:36 UTC, Cosimo Cecchi
  Details

Description Cosimo Cecchi 2011-03-29 17:23:18 UTC
As we use symbolic icons everywhere else in that dialog, the ad-hoc one should be symbolic too, see attached screenshot.
Comment 1 Cosimo Cecchi 2011-03-29 17:23:32 UTC
Created attachment 184610 [details]
screenshot
Comment 2 Cosimo Cecchi 2011-03-29 18:25:22 UTC
Created attachment 184616 [details] [review]
network: use symbolic icon for ad-hoc wireless connections

Use network-workgroup-symbolic
Comment 3 Cosimo Cecchi 2011-03-29 18:35:14 UTC
Created attachment 184618 [details] [review]
Additional patch, which closes the gap between the signal and mode if no security icon is dipslayed.

network: hide the security cell renderer if there's no icon to display

This allows the mode renderer which is on the left to slide in and
replace it in case.
Comment 4 Cosimo Cecchi 2011-03-29 18:36:58 UTC
Created attachment 184619 [details]
screenshot after patch
Comment 5 Cosimo Cecchi 2011-03-29 18:59:34 UTC
Pushing after r-t approval.

Attachment 184616 [details] pushed as 44847a5 - network: use symbolic icon for ad-hoc wireless connections