GNOME Bugzilla – Bug 646121
network: signal strength icons in the menu are not aligned
Last modified: 2011-04-04 13:31:20 UTC
It seems the signal strength icons are not properly aligned in the NM menu. See attached screenshot.
Created attachment 184601 [details] screenshot
part of that is because you don't have the latest gnome-icon-theme-symbolic, and so you're not seeing the lock icons on the secure networks. But yeah, even with that, it's wrong, which is weird because I totally remember changing things to make things line up right...
Created attachment 184603 [details] [review] network: fix alignment of secure vs insecure wireless icons Since the icon area is end-aligned, the signal strength icon for insecure networks was ending up aligned with the lock icon for secure networks. Fix that by always including a _secureIcon, but having it be blank for the insecure networks.
Review of attachment 184603 [details] [review]: Looks right and works as advertised.
Created attachment 184630 [details] screenshot with icons
(In reply to comment #5) > Created an attachment (id=184630) [details] > screenshot with icons That's without Dan's patch, right?
Florian, correct. Would be really nice to fix this.
I'm a bit late, but I think that the right fix is to place secure icons on the left, so wireless icons are always right aligned at the end. Otherwise this bug comes back with private connections and adhocs, that use plain PopupImageMenuItem.
(In reply to comment #8) > I'm a bit late, but I think that the right fix is to place secure icons on the > left, so wireless icons are always right aligned at the end. I did it according to https://live.gnome.org/GnomeShell/Design/Guidelines/SystemStatus/Network. > Otherwise this bug comes back with private connections and adhocs, that use > plain PopupImageMenuItem. Can't ad-hoc connections be either secure or insecure too? I guess in the private case we can't tell whether the connection is secure or not? But we can tell its signal strength? That seems weird...
(In reply to comment #9) > (In reply to comment #8) > > I'm a bit late, but I think that the right fix is to place secure icons on the > > left, so wireless icons are always right aligned at the end. > > I did it according to > https://live.gnome.org/GnomeShell/Design/Guidelines/SystemStatus/Network. The high and low fidelity mockups actually differ there... there may not be a lot of intent. I think for 3.0.0 we should just go as we have a patch here then ask the designers - I'm not worried if the ordering changes for 3.0.1.
Review of attachment 184603 [details] [review]: r-t approval https://mail.gnome.org/archives/release-team/2011-April/msg00034.html
Attachment 184603 [details] pushed as 7932585 - network: fix alignment of secure vs insecure wireless icons