GNOME Bugzilla – Bug 646118
[gstmultiqueue] if arbitrary sink number is specified by caller, use this as single queue id
Last modified: 2011-03-30 08:53:24 UTC
use sscanf to extract desired sink number if explicitely specified. otherwise use zero based counter
Created attachment 184599 [details] [review] [gstmultiqueue] if arbitrary sink number is specified by caller, use this as single queue id
Created attachment 184600 [details] [review] [gstmultiqueue] if arbitrary sink number is specified by caller, use this as single queue id
Review of attachment 184600 [details] [review]: ::: plugins/elements/gstmultiqueue.c @@ +598,3 @@ + sscanf (name + 4, "%d", &id); + } else + id = mqueue->nbqueues++; You should hold the multiqueue mutex while accessing the nbqueues variable. Also double check (while holding that mutex) that the ID is not used yet when a name was provided by the caller
Created attachment 184635 [details] [review] [gstmultiqueue] if arbitrary sink number is specified by caller, use as single queue id if not already taken, otherwise increase until free not sure if this behaviour is what you intendend, or if you preferred erroring out in case the pad/id number already exist
commit 8db570f48cf129ae28e36bab58729017d7577a78 Author: Sebastian Dröge <sebastian.droege@collabora.co.uk> Date: Wed Mar 30 10:48:47 2011 +0200 multiqueue: Make assignment of queue IDs and pad names threadsafe Also add a test for naming pads by the caller and return NULL when requesting an already existing pad. commit 5368406a57bbc8e2a72768797a16302aa888907f Author: Andreas Frisch <fraxinas@opendreambox.org> Date: Tue Mar 29 23:58:43 2011 +0200 multiqueue: Set the single queue ID to the ID of the requested pad if one wa