GNOME Bugzilla – Bug 646074
NetworkManager 0.9 indicator doesn't show device name
Last modified: 2011-04-11 14:46:06 UTC
In the current NM 0.9 indicator doesn't show device names. This is pretty bad for me that i have a broken wifi card and i have to figure out which one is the good one. This is a regression from 0.8 applet.
Created attachment 184574 [details] [review] NetworkMenu: fixup device descriptions Fix some bugs in Util.fixupPCIDescription(), that caused all device descriptions to be empty.
Comment on attachment 184574 [details] [review] NetworkMenu: fixup device descriptions >- 'Intel?', >+ 'Intel', nm-applet has the "?". (I remember checking before because it seemed weird.) I guess it was a bug there and it's been fixed now? The rest looks right. (Marking commit-after-freeze; talk to Owen if you want to commit-now.)
actually, this will presumably change UI as well?
(In reply to comment #2) > (From update of attachment 184574 [details] [review]) > >- 'Intel?', > >+ 'Intel', > > nm-applet has the "?". (I remember checking before because it seemed weird.) I > guess it was a bug there and it's been fixed now? No, it's still there in network-manager-applet. Don't know for sure if it is a bug, but I don't think we want to strip "Intel?" but not "Intel". Anyway, I'm fine with postponing this to 3.0.1, or to 3.1.1 if UI freeze applies.
If it's like the 0.8 applet it should change the UI a bit so it can display the device name. Please consider this for 3.0 since it will affect users with more than one device.
(In reply to comment #5) > If it's like the 0.8 applet it should change the UI a bit so it can display the > device name. Please consider this for 3.0 since it will affect users with more > than one device. Uhm... aren't you seeing like two empty spaces, above each network device?
(In reply to comment #6) > (In reply to comment #5) > > If it's like the 0.8 applet it should change the UI a bit so it can display the > > device name. Please consider this for 3.0 since it will affect users with more > > than one device. > > Uhm... aren't you seeing like two empty spaces, above each network device? Yep!!
Are both devices managed by NM? Do you see any error on stdout?
(In reply to comment #8) > Are both devices managed by NM? Yes, two wifi devices: one usb and another internal pci. NM runs the two without any problems but the indicator doesn't display the name of them. > Do you see any error on stdout? No luck on this one :/
Created attachment 184825 [details] [review] NetworkMenu: fix some bugs for status items When more than one device exists, we need to reset the section title's device to null, and in that case we must show nothing (neither the switch nor the label, but an empty label is OK anyway). Also, we need to update the device statusItem immediately when constructing it, as we may not get any state-changed.
*** Bug 646128 has been marked as a duplicate of this bug. ***
Comment on attachment 184825 [details] [review] NetworkMenu: fix some bugs for status items >+ this.statusItem.setStatus(this.getStatusLabel()); >+ this.statusItem.setToggleState(this.connected); it seems like it would be better to run this._deviceStateChanged(), or at least, to have both cases call some common subroutine. Otherwise at some point we're going to add something to deviceStateChanged() and forget that we have to add it here as well. >- if (this.titleItem) >- this.titleItem.destroy(); >+ if (this.statusItem) >+ this.statusItem.destroy(); obviously correct >+ item.updateForDevice(null); That should probably get a comment explaining what/why. Also, this is not new with your patches, but if I connect and then disconnect a USB ethernet device, the "Wired" heading goes back to behaving like it's supposed to, and the entry for my built-in ethernet disappears, but the entry for the USB ethernet device is still there, with the status "invalid".
(In reply to comment #12) > (From update of attachment 184825 [details] [review]) > Also, this is not new with your patches, but if I connect and then disconnect a > USB ethernet device, the "Wired" heading goes back to behaving like it's > supposed to, and the entry for my built-in ethernet disappears, but the entry > for the USB ethernet device is still there, with the status "invalid". Do ModemManager / NetworkManager still expose the device? (You can check in d-feet) Can you confirm that NMApplet._deviceRemoved is called? Can you confirm that NMDevice.destroy is called, on the right device?
Created attachment 185335 [details] [review] NetworkMenu: fix some bugs for status items When more than one device exists, we need to reset the section title's device to null, and in that case we must show nothing (neither the switch nor the label, but an empty label is OK anyway). Also, we need to update the device statusItem immediately when constructing it, as we may not get any state-changed.
Created attachment 185337 [details] [review] NetworkMenu: fix some bugs for status items When more than one device exists, we need to reset the section title's device to null, and in that case we must show nothing (neither the switch nor the label, but an empty label is OK anyway). Also, we need to update the device statusItem immediately when constructing it, as we may not get any state-changed. Forgot to git add one piece.
Comment on attachment 185337 [details] [review] NetworkMenu: fix some bugs for status items looks good (on the other problem: device-removed is not being emitted. I'll poke around in NM)
Attachment 184574 [details] pushed as b2b685e - NetworkMenu: fixup device descriptions Attachment 185337 [details] pushed as 2d855ce - NetworkMenu: fix some bugs for status items