GNOME Bugzilla – Bug 64601
GtkAdjustment needs properties
Last modified: 2011-02-04 16:12:26 UTC
A valid GtkAdjustment can not be instantiated with only g_object_new(). The object fields that are set directly in gtk_adjustment_new() should be get/set-able via the properties system. This has been punted from the GTK+2.0 target milestone.
Created attachment 17382 [details] [review] Provides properties for GtkAdjustment's fields.
Added PATCH keyword so it shows up on radar.
Will this make the 2.4 API freeze?
The patch seems to restrict all double properties to positive values. Why is that ?
Ray?
Oops. Yea, that was a mistake on my part. It looks like I also forgot to do object notification when the properties change. I'll submit a patch to fix those problems sometime tonight.
Created attachment 18589 [details] [review] Updated GtkAdjusment properties patch
Could someone please review this patch, or at least give it a target milestone?
This looks good to me, other than the very minor indentation nit on the object property registration. Putting for 2.4 milestone.
Was that a "please commit"?
May I commit this patch?