GNOME Bugzilla – Bug 645943
[camerabin2] Provide a video orientation
Last modified: 2018-11-03 13:07:51 UTC
It would be very useful to set the video orientation of the captured video, both for cameras and IM application (make the orientation depend on device orientation) It would be nice to have a GstVideoOrientation interface on all CameraSrc implementations. It's relatively easy for a user to fake, but having two code-patch in a CameraSrc using apps for (for when the src provides video-orientation and for when not). I'm not very familiar with the design of GstBaseCameraSrc, but a potentialy suggested way would be to have GstBaseCameraSrc automatically put in a videoflip unless the implementation indicates it can do this in hardware.
About adding it to camera sources, I agree that it is a good idea, we could do it in 2 ways: 1) Add it as a recommended or obligatory interface in the camera source writing guide (I'm writing one and it might even have conformance tests!) and people implement it the way they want in their sources, using hardware or not. And then we add it to our wrappercamerabinsrc. 2) Make basecamerasrc implement it and make it use software in case the subclass didn't implement it. I don't particularly like 2 because we don't have elements in basecamerasrc, it only contains properties/API/helper functions.
Option two would have the advantage of applying the fallback to whatever camerasrc is beeing used, where option might cause duplicated code. That said, I still prefer option 1. as well. I also wonder if the same should be done for a videobalance interface. On the other hand applying software balance to a camerasrc is not realy helpful ...
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/38.