After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645931 - [gstmultiqueue] fix arbitrary sink + source pad naming
[gstmultiqueue] fix arbitrary sink + source pad naming
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-28 11:52 UTC by Andreas Frisch
Modified: 2011-03-29 09:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[gstmultiqueue] fix arbitrary sink + source pad naming (2.46 KB, patch)
2011-03-28 11:52 UTC, Andreas Frisch 		needs-work Details | Review
[gstmultiqueue] fix arbitrary sink + source pad naming (2.56 KB, patch)
2011-03-28 19:02 UTC, Andreas Frisch 		committed Details | Review

Description Andreas Frisch 2011-03-28 11:52:24 UTC 
gst_single_queue_new used actually requested name to assign the pad names instead of the 0-based queue id
Comment 1 Andreas Frisch 2011-03-28 11:52:27 UTC 
Created attachment 184444 [details] [review]
[gstmultiqueue] fix arbitrary sink + source pad naming
Comment 2 Sebastian Dröge (slomo) 2011-03-28 18:09:47 UTC 
Review of attachment 184444 [details] [review]:

::: plugins/elements/gstmultiqueue.c
@@ +1754,3 @@
+    name = g_strdup_printf ("sink%d", sq->id);
+
+  sq->sinkpad = gst_pad_new_from_static_template (&sinktemplate, name);

You are leaking the name string here if no names was provided by the caller
Comment 3 Andreas Frisch 2011-03-28 19:02:30 UTC 
Created attachment 184496 [details] [review]
[gstmultiqueue] fix arbitrary sink + source pad naming

fixed name leaking
Comment 4 Sebastian Dröge (slomo) 2011-03-29 09:33:33 UTC 
commit 86bbc85ab1be0122da883066626eea1a49eed1e8
Author: Fraxinas <andreas.frisch@multimedia-labs.de>
Date:   Mon Mar 28 21:01:13 2011 +0200

    multiqueue: Fix arbitrary sink + source pad naming
    
    Use the string provided by the caller for the sinkpad name
    if possible. Note that all sanity checking for this name
    is already done in GstElement.
    
    Fixes Bug #645931