After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645824 - Comboboxes, buttons and spin boxes are the wrong height
Comboboxes, buttons and spin boxes are the wrong height
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
git master
Other Linux
: Normal normal
: 3.0
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
[theme]
: 643672 (view as bug list)
Depends on: 646882
Blocks:
 
 
Reported: 2011-03-27 13:32 UTC by Allan Day
Modified: 2011-04-12 21:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the date and time panel. With added eek! (96.17 KB, image/png)
2011-03-27 13:32 UTC, Allan Day
  Details
adwaita: make button, spinbutton, combobox and entry height consistent (3.15 KB, patch)
2011-04-07 15:57 UTC, Cosimo Cecchi
committed Details | Review

Description Allan Day 2011-03-27 13:32:25 UTC
Created attachment 184362 [details]
Screenshot of the date and time panel. With added eek!

I'm filing this against gnome-themes-standard in full awareness that it is probably not the right module to be bugging (so to speak). I'm afraid I don't know which module is the right one, however.

So, height issues. Currently, comboboxes are 39px high, buttons are 35px high and spin boxes are 29px high. Not only are these too high stylistically speaking, but the inconsistency between the heights makes for some bad layouts. See the attached screenshot for a rather tasty example.

Jimmac says that all of these widgets should be 26px high.
Comment 1 Cosimo Cecchi 2011-03-28 14:32:43 UTC
*** Bug 643672 has been marked as a duplicate of this bug. ***
Comment 2 Cosimo Cecchi 2011-04-07 15:57:52 UTC
Created attachment 185433 [details] [review]
adwaita: make button, spinbutton, combobox and entry height consistent

This patch together with the GTK+ patchset fixes the bug.
Comment 3 Cosimo Cecchi 2011-04-12 21:20:13 UTC
This is now fixed.
Comment 4 Allan Day 2011-04-12 21:23:00 UTC
Woot!