After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645813 - Fail to upload new release
Fail to upload new release
Status: RESOLVED FIXED
Product: sysadmin
Classification: Infrastructure
Component: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Sysadmins
GNOME Sysadmins
Depends on:
Blocks:
 
 
Reported: 2011-03-27 09:37 UTC by jessevdk@gmail.com
Modified: 2011-03-28 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description jessevdk@gmail.com 2011-03-27 09:37:38 UTC
I just tried to upload a new release of gitg and got the following trace from the ftpadmin script:

[jessevdk@master ~]$ ftpadmin install gitg-0.1.1.tar.bz2 
Gathering information and sorting on version: ., done
Preparing installation of gitg-0.1.1.tar.bz2:
Traceback (most recent call last):
  • File "/usr/local/bin/ftpadmin", line 1580 in <module>
    main()
  • File "/usr/local/bin/ftpadmin", line 1565 in main
    options.func(options, parser)
  • File "/usr/local/bin/ftpadmin", line 1314 in cmd_install
    module.install(unattended=options.unattended)
  • File "/usr/local/bin/ftpadmin", line 862 in install
    if not self.validate():
  • File "/usr/local/bin/ftpadmin", line 836 in validate
    if self.version in self.fileinfo.versions:
AttributeError: 'TarInfo' object has no attribute 'versions'

I did not see the announcement in time, so it would be nice if this release could still be pushed (since I already pushed to git and tagged the release). I will fix my doap file after (it's missing the longer description for example).
Comment 1 Olav Vitters 2011-03-27 11:42:37 UTC
Sorry... I really tested everything except this one line which is in the non-DEBUG codepath...

Anyways, please try again.

Feedback on the script is very welcome btw. Would love if you could copy/paste the output of a successful run.
Comment 2 jessevdk@gmail.com 2011-03-27 11:44:54 UTC
[jessevdk@mastftpadmin install gitg-0.1.1.tar.bz2 
Gathering information and sorting on version: ., done
Preparing installation of gitg-0.1.1.tar.bz2:
 - Checking consistency: .., done
 - Checking previous tarball: .., done
 - NEWS, done (diff, 6 lines)
 - ChangeLog, done (diff, 6026 lines)
 - Copying tar.bz2, done
 - Creating tar.gz from tar.bz2: .., done
 - Creating sha256sum, done

      Module: gitg
     Version: 0.1.1   (previous version: 0.1.0)
 Destination: /ftp/pub/GNOME/sources/gitg/0.1/

Install gitg? [Y/n] y
Installing gitg-0.1.1.tar.bz2:
 - Moving files: ....., done
 - Updating LATEST-IS, done
 - Updating known versions, done
Doing notifications:
 - Informing ftp-release-list, done
 - Triggering GNOME library update, done
 - Adding new version to GNOME BugzillaBugzilla version 0.1.x exists for product gitg
, done
 - Triggering ftp.gnome.org updateBugzilla version 0.1.x exists for product gitg
, done

Your tarball will appear in the following location on ftp.gnome.org:

  http://download.gnome.org/sources/gitg/0.1/

It is important to retain the trailing slash for compatibility with
broken http clients, and to use http as it is less taxing on the server.

e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  gitg-0.1.1.news
54af17ea947ea6ed53697624de331b779ee3f4c13d08011a0be993671cbf4788  gitg-0.1.1.changes
39b2d5a7a5e7515d4914fa980f29a8b46867d69404ab9b711fa50c2d0e5b02b9  gitg-0.1.1.tar.bz2
9e849c91ca5acb0e685a51e47c9eee7c58d6cbeab185bb236d0f80d690acca4b  gitg-0.1.1.tar.gz

The ftp-release-list email uses information from the modules DOAP file. Make
sure at least the following fields are filled in:
  name, shortdesc, description, download-page, bug-database
See http://live.gnome.org/MaintainersCorner#doap

Please report any problems to:
https://bugzilla.gnome.org/enter_bug.cgi?product=sysadmin
Comment 3 Olav Vitters 2011-03-27 12:24:08 UTC
Thanks!

Changed 3 things due to that output:
1. Didn't call the signal-ftp-sync command correctly (duplicate Bugzilla output)
2. NEWS file wasn't flushed, so output appeared to be 0
3. Writing json files would open the existing file; result: group could not be changed (discovered this while fixing the other 2 problems)
Comment 4 jessevdk@gmail.com 2011-03-27 14:16:51 UTC
Two small issues:

There appear to be missing some newlines in the output from the script:

 - Adding new version to GNOME BugzillaBugzilla version 0.1.x exists for product gitg
, done
 - Triggering ftp.gnome.org updateSignalling churchill.acc.umu.se
, done

Also, the == News == header seems to be missing now in the announcement e-mail:
http://mail.gnome.org/archives/ftp-release-list/2011-March/msg00264.html
Comment 5 Olav Vitters 2011-03-27 14:50:16 UTC
The following is what I expected:
"Bugzilla version 0.1.x exists for product gitg"
"Signalling churchill.acc.umu.se"

It calls 'curl' and 'signal-ftp-sync'. I'll clean up the output once ftpadmin works reliability. Until that time I don't want to impact the fallback (install-module on window).

The header:
> News
> ====

Is dropped when the first line contains the new version number. This so you can do this in your NEWS file:

> gitg 0.2.1
> ==========

and have it appear nicely in the output. I think I'll have to add some magic to that. But I'll have to check the output of various of these emails to see.

I've also tried to fix the extra spaces in the description while still allowing an intend (GNOME Shell does that).
Comment 6 Olav Vitters 2011-03-28 20:04:51 UTC
I've changed how it does the News. It'll always show the header. It'll ignore any lines with punctuation (stuff like "====" or "----"), empty lines, and up to 1 line where the version number is in the line.

Result is a nicer announcement message.