After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645693 - Calendar day names and "all day" badly ellipsized in French
Calendar day names and "all day" badly ellipsized in French
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: calendar
2.91.x
Other Linux
: Normal major
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
[gnome3-important]
: 651325 658679 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-03-25 23:26 UTC by Milan Bouchet-Valat
Modified: 2013-01-10 10:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the buggy calendar view (44.68 KB, image/png)
2011-03-25 23:26 UTC, Milan Bouchet-Valat
  Details
gnome-shell.css: fix multiple calendar layout issues (2.00 KB, patch)
2011-03-30 16:41 UTC, Dan Winship
none Details | Review
gnome-shell.css: fix multiple calendar layout issues (2.00 KB, patch)
2011-03-31 17:38 UTC, Dan Winship
committed Details | Review

Description Milan Bouchet-Valat 2011-03-25 23:26:02 UTC
See attached screenshot. French for "All day" is "Toute la journée", which is much longer and gets ellipsized.

Even worse are day names, which don't appear at all. This is probably because they are longer than English ones: they're "Dim.", "Lun.", "Mar.", "Mer.", "Jeu.", "Ven.", "Sam." (from Sunday to Saturday). Maybe we can get rid of the extraneous dot, but generally it would be good for the Shell to support locales that need wide labels by expanding the view (there's plenty of space left anyway).

I'd say it's a blocker for 3.0, unless we consider it's up to translators to use shorter abbreviations (but that's likely not possible everywhere).
Comment 1 Milan Bouchet-Valat 2011-03-25 23:26:50 UTC
Created attachment 184254 [details]
Screenshot of the buggy calendar view
Comment 2 Dan Winship 2011-03-30 16:41:21 UTC
Created attachment 184712 [details] [review]
gnome-shell.css: fix multiple calendar layout issues

Specifying absolute pixel widths for fields breaks under both font
scaling and translation.

Change all px lengths in the calendar to corresponding pt values, to
fix the layout under larger/smaller font sizes.

Change all "width" specifications to "min-width", for languages with
longer translations. This completely breaks the layout if any field
exceeds the min-width of its column, but that is preferable to
ellipsizing. Needs to be redone using St.Table or the like for 3.0.1.

Also add padding to the right of the calendar popup to match the
padding on the left, since the lack of it becomes more obvious in
layouts where the actual width exceeds the minimum width.
Comment 3 Vincent Untz 2011-03-31 15:20:20 UTC
The patch solves the bug for "All day", but the day names for appointments happening this week still appear as "..."
Comment 4 Dan Winship 2011-03-31 17:38:10 UTC
Created attachment 184806 [details] [review]
gnome-shell.css: fix multiple calendar layout issues

oops, missed one
Comment 5 Vincent Untz 2011-04-01 04:11:32 UTC
Last patch works fine, indeed.
Comment 6 Owen Taylor 2011-04-01 17:14:40 UTC
Review of attachment 184806 [details] [review]:

> Change all px lengths in the calendar to corresponding pt values, to
> fix the layout under larger/smaller font sizes.

Is sort of confusing because there are some px left - like the overall width of the calendar. (which this patch changes to a min-width) - that shows up at small font sizes.

But the contents of the patch look fully safe to me, and it works in testing. Good pending r-t approval.
Comment 8 Dan Winship 2011-04-02 11:33:35 UTC
Comment on attachment 184806 [details] [review]
gnome-shell.css: fix multiple calendar layout issues

pushed. leaving the bug open so we can eventually fix it without
breaking the alignment

Attachment 184806 [details] pushed as 6b95a35 - gnome-shell.css: fix multiple calendar layout issues
Comment 9 Dan Winship 2011-05-31 13:13:32 UTC
*** Bug 651325 has been marked as a duplicate of this bug. ***
Comment 10 Dan Winship 2011-09-12 13:11:43 UTC
*** Bug 658679 has been marked as a duplicate of this bug. ***
Comment 11 Stéphane Démurget 2012-11-05 01:59:38 UTC
This bug has been fixed, can it be marked resolved/fixed please?
Comment 12 Milan Bouchet-Valat 2013-01-10 10:48:25 UTC
Sure... ;-)