GNOME Bugzilla – Bug 645687
Can't access TotemObject from Python plugins
Last modified: 2011-03-27 04:21:36 UTC
This issue appears for all plugins written in Python, e.g. for the subtitles plugin: /opt/gnome3/lib/python2.6/site-packages/gobject/propertyhelper.py:159: Warning: g_object_set_qdata: assertion `G_IS_OBJECT (object)' failed value = instance.get_property(self.name) Traceback (most recent call last):
+ Trace 226447
self.manager = self.totem.get_ui_manager()
Supposedly this statement does not work as excepted (might be related to the warning above): object = gobject.property(type = gobject.GObject) Not sure if that's a bug in Totem or pygobject. I've build everything with jhbuild, thus everything is current master.
Just checked with Fedora 15, same problem there. In my humble opinion that's a blocker.
Created attachment 184281 [details] [review] Retrieve "object" property containing the TotemObject in do_activate instead of __init__, because in the latter case it would be None.
Thanks for the patch Sebastian. Philip will be testing the patch, and requesting freeze break as appropriate today. Thanks Philip!
Review of attachment 184281 [details] [review]: Looks good to me, and seems to work. This brings the behaviour of the Python plugins in line with what the C plugins do, which can never be bad. Please commit if/when we get approval for a code freeze break. I'm asking for one now. Thanks.
Comment on attachment 184281 [details] [review] Retrieve "object" property containing the TotemObject in do_activate instead of __init__, because in the latter case it would be None. Committed with a fixed up commit message.