After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645676 - Vimeo needs quotations in header params even if they are tokens
Vimeo needs quotations in header params even if they are tokens
Status: RESOLVED DUPLICATE of bug 641280
Product: libsoup
Classification: Core
Component: HTTP Transport
unspecified
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2011-03-25 21:19 UTC by Eitan Isaacson
Modified: 2011-03-30 22:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Half baked fix (1.48 KB, patch)
2011-03-25 21:19 UTC, Eitan Isaacson
none Details | Review
Use quoted values in Content-Disposition headers. (4.00 KB, patch)
2011-03-30 22:58 UTC, Eitan Isaacson
none Details | Review

Description Eitan Isaacson 2011-03-25 21:19:38 UTC
Created attachment 184235 [details] [review]
Half baked fix

When uploading videos to Vimeo's endpoint with a POST multipart/form-data, it will return a 500 error if Content-Disposition param values are not quoted. *sigh*

I mentioned it in their forums:
http://vimeo.com/forums/topic:35969
Comment 1 Dan Winship 2011-03-25 21:48:27 UTC
yeah, someone else hit this too.

the half-baked fix won't work because there are servers with the opposite bug (will only accept tokens) on other headers.

the 3/4-baked fix would be to make soup-multipart.c just call soup_header_g_string_append_param_quoted(), except that would break UTF-8-encoded filename parameters.

I think the fully-baked fix is to rearrange the code in soup_header_g_string_append_param() and soup_header_g_string_append_param_quoted() so that _quoted() can handle both quoted-strings and UTF-8, and then make soup-multipart use that.

*** This bug has been marked as a duplicate of bug 641280 ***
Comment 2 Eitan Isaacson 2011-03-30 22:58:01 UTC
Created attachment 184748 [details] [review]
Use quoted values in Content-Disposition headers.

This fixes a Vimeo bug where its upload endpoint only accepts
Content-Disposition values that are quoted. Even though RFC 2231 explicity
says that servers should accept mix of quoted and unquoted values.
http://vimeo.com/forums/topic:35969