GNOME Bugzilla – Bug 645629
Some public symbols are missing for libpeas
Last modified: 2011-04-01 16:01:45 UTC
The following symbols are exported by the seed library but are marked as private. Anyhow, libpeas would make good use of them or a similar feature. This symbol handling GValues looks clean and is already used by libpeas 0.7 (shame!) gboolean seed_gvalue_from_seed_value (SeedContext ctx, SeedValue val, GType type, GValue *gval, SeedException *exception); The following ones have a more "private" look so we didn't use them yet despite we have a patch doing so: GIArgument <-> JSValue gboolean seed_gi_make_argument (SeedContext ctx, SeedValue value, GITypeInfo *type_info, GIArgument *arg, SeedException *exception); SeedValue seed_gi_argument_make_js (SeedContext ctx, GIArgument *arg, GITypeInfo *type_info, SeedException *exception); Maybe they should get exported publicly with a name such as seed_gi_argument_from_seed_value() and seed_gi_argument_to_seed_value() or something ?
Created attachment 184202 [details] [review] Expose seed_value_to_gvalue
Created attachment 184203 [details] [review] Expose seed_value_(to|from)_gi_argument
These look good to go. can you commit them in.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Do you have an idea when this patch will make it to a released version of libpeas? Could you make a release soon so we can have a RC of libpeas out depending on that seed version.
Tim's the one who releases - might be worth giving him a nudge. (he should be on the cc list on this bug)
Tim, could you please make a release? I'm blocking on it to be able to make a new release of libpeas...
Will do, later today.