After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645613 - Links in notifications stopped working
Links in notifications stopped working
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: message-tray
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
[gnome3-important]
Depends on:
Blocks:
 
 
Reported: 2011-03-23 19:24 UTC by Marina Zhurakhinskaya
Modified: 2011-03-25 22:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
messageTray: fix clicking on links again (1.16 KB, patch)
2011-03-23 20:10 UTC, Dan Winship 		committed Details | Review

Description Marina Zhurakhinskaya 2011-03-23 19:24:44 UTC 
This is likely because we made the notification actor a StButton.
Comment 1 Dan Winship 2011-03-23 20:10:01 UTC 
Created attachment 184167 [details] [review]
messageTray: fix clicking on links again

The change to make Notification an StButton (06d2c0af, bug 642978)
broke links, because the link actor would ignore the
button-press-event, allowing the notification actor to receive it and
get a pointer grab, and so the link actor would never see the
button-release-event. Fix that by accepting and discarding the
button-press-event.
Comment 2 Marina Zhurakhinskaya 2011-03-23 20:36:57 UTC 
Review of attachment 184167 [details] [review]:

Good to commit once we get a permission to do so.
Comment 3 Matthias Clasen 2011-03-25 21:56:16 UTC 
Not sure about comment conventions in the shell code base, but I'd add a comment there why it is useful to connect a trivial signal handler...
Comment 4 Owen Taylor 2011-03-25 21:59:35 UTC 
Review of attachment 184167 [details] [review]:

+2 from release team and sign-off from me. (Matthias's suggested comment might indeed be useful.)
Comment 5 Dan Winship 2011-03-25 22:50:21 UTC 
Attachment 184167 [details] pushed as 31b1263 - messageTray: fix clicking on links again