After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645577 - Theme tweaks
Theme tweaks
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-22 23:15 UTC by Cosimo Cecchi
Modified: 2011-03-31 18:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
plugins-engine: set dialog hint to configuration widgets if possible (1.23 KB, patch)
2011-03-22 23:15 UTC, Cosimo Cecchi
committed Details | Review
shell: add the primary-toolbar class style to the toolbar (1001 bytes, patch)
2011-03-22 23:15 UTC, Cosimo Cecchi
committed Details | Review
source-header: slightly tweak the header toolbar appearance (1.28 KB, patch)
2011-03-22 23:15 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2011-03-22 23:15:08 UTC
Hi, attached are some patches that make rhythmbox play nicer with the GNOME3 default theme.
Comment 1 Cosimo Cecchi 2011-03-22 23:15:10 UTC
Created attachment 184138 [details] [review]
plugins-engine: set dialog hint to configuration widgets if possible

So they get themed up by mutter correctly.
Comment 2 Cosimo Cecchi 2011-03-22 23:15:13 UTC
Created attachment 184139 [details] [review]
shell: add the primary-toolbar class style to the toolbar
Comment 3 Cosimo Cecchi 2011-03-22 23:15:16 UTC
Created attachment 184140 [details] [review]
source-header: slightly tweak the header toolbar appearance

Remove border, and uncomment the style context parsing.
Comment 4 Jonathan Matthew 2011-03-23 22:02:14 UTC
Review of attachment 184138 [details] [review]:

looks OK
Comment 5 Jonathan Matthew 2011-03-23 22:04:47 UTC
Review of attachment 184139 [details] [review]:

I've been trying to figure out whether I want this to happen or not, guess we'll try it out and see..
Comment 6 Jonathan Matthew 2011-03-23 22:07:47 UTC
Review of attachment 184140 [details] [review]:

I was meaning to do this, never quite got around to it though.
Comment 7 Cosimo Cecchi 2011-03-31 18:52:00 UTC
These have been committed a few days ago, while BZ was down. Closing now.