After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645569 - Add equal () to StructuredName
Add equal () to StructuredName
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks: 645570
 
 
Reported: 2011-03-22 21:21 UTC by Raul Gutierrez Segales
Modified: 2011-03-30 13:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add equal () method to StructuredName (1.17 KB, patch)
2011-03-22 21:21 UTC, Raul Gutierrez Segales 		accepted-commit_now Details | Review

Description Raul Gutierrez Segales 2011-03-22 21:21:18 UTC 
Created attachment 184127 [details] [review]
Add equal () method to StructuredName

This convenience method allows to easily compare if 2 StructuredNames are the same. Its specially useful with the Tracker backend where updates to StructuredName happen in a very granular fashion.
Comment 1 Philip Withnall 2011-03-29 23:17:32 UTC 
Review of attachment 184127 [details] [review]:

Looks good to me apart from the two documentation comments below. Don't forget to add API and bug fix entries to NEWS.

::: folks/name-details.vala
@@ +167,2 @@
   /**
+   * Whether to StructuredNames are the same.

s/to/two/

StructuredNames should probably be {@link}ed.
Comment 2 Raul Gutierrez Segales 2011-03-30 13:39:17 UTC 
Merged:

commit 1c2765353e583dfaba53506fd6776372ef7dc149
Author: Raul Gutierrez Segales <raul.gutierrez.segales@collabora.co.uk>
Date:   Tue Mar 22 21:16:28 2011 +0000

    Add equal method to StructuredName

 NEWS                    |    3 +++
 folks/name-details.vala |   17 +++++++++++++++++
 2 files changed, 20 insertions(+), 0 deletions(-)