After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645521 - make distcheck fails with "files left in build directory" message
make distcheck fails with "files left in build directory" message
Status: RESOLVED DUPLICATE of bug 643128
Product: folks
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: Unset
Assigned To: folks-maint
folks-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-22 13:41 UTC by Raul Gutierrez Segales
Modified: 2011-03-22 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add missing files to CLEANFILES (1.41 KB, patch)
2011-03-22 13:42 UTC, Raul Gutierrez Segales 		rejected Details | Review

Description Raul Gutierrez Segales 2011-03-22 13:41:24 UTC 
When running make distcheck (regardless of enabling or not the Tracker backend) I get this error:

ERROR: files left in build directory after distclean:
./tests/lib/telepathy/contactlist/tp-test-contactlist.gir
./tests/lib/telepathy/contactlist/tp-test-contactlist.vapi
./backends/telepathy/lib/tp-lowlevel.gir
./backends/telepathy/lib/tp-lowlevel.vapi
make[1]: *** [distcleancheck] Error 1
make[1]: Leaving directory `/home/rgs/devel/folks/folks-0.5.0.1.20110322/_build'
make: *** [distcheck] Error 1

The attached patch fixes the problem, although I am dubious of the approach.
Comment 1 Raul Gutierrez Segales 2011-03-22 13:42:03 UTC 
Created attachment 184060 [details] [review]
Add missing files to CLEANFILES
Comment 2 Travis Reitter 2011-03-22 15:12:58 UTC 
Review of attachment 184060 [details] [review]:

Unfortunately, we can't do this if we want to make 'make clean' safe in release tarballs. That would suddenly add build dependencies on Vala and gobject-introspection, which we want to avoid for release tarballs.
Comment 3 Travis Reitter 2011-03-22 15:13:29 UTC 
Thanks for the bug report. This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 643128 ***