After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645460 - I can't read the whole shortcuts descriptions
I can't read the whole shortcuts descriptions
Status: RESOLVED OBSOLETE
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
[gnome3-important]
Depends on:
Blocks:
 
 
Reported: 2011-03-21 21:05 UTC by Juanjo Marín
Modified: 2020-11-13 16:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Keyboard settings window (67.27 KB, image/png)
2011-03-21 21:05 UTC, Juanjo Marín
  Details
keyboard panel wrapping labels (147.47 KB, image/png)
2018-01-24 13:25 UTC, Georges Basile Stavracas Neto
  Details
data: Don't expose horizontal workspace keybindings to Settings (1.70 KB, patch)
2018-01-24 16:09 UTC, Florian Müllner
committed Details | Review
data: Don't expose window shading shortcut (1.14 KB, patch)
2018-01-24 16:44 UTC, Florian Müllner
committed Details | Review

Description Juanjo Marín 2011-03-21 21:05:15 UTC
Created attachment 184001 [details]
Keyboard settings window

I can't read the whole shortcuts descriptions in my system. The keyboard settings window is too shot and I can't resize/maximize and I can't find another way to get this info like tooltips or whatever.
Comment 1 Bastien Nocera 2011-03-22 14:15:51 UTC
Those strings need cleaning up I think, metacity and mutter share those strings, but nobody seems to have cleaned them up.
Comment 2 Juanjo Marín 2011-03-22 21:34:46 UTC
Don't forget that we don't know how long these strings are when they are translated.

As user, I think I should be able to read the descriptions because there is enough screen for a bigger window :(
Comment 3 André Klapper 2011-03-28 05:41:34 UTC
As a quick and dirty workaround, could these descriptions have a tooltip by default?
Comment 4 Jonas Ådahl 2018-01-24 09:36:55 UTC
Mutter doesn't have a keyboard settings window.
Comment 5 Bastien Nocera 2018-01-24 11:15:27 UTC
(In reply to Jonas Ådahl from comment #4)
> Mutter doesn't have a keyboard settings window.

It's gnome-control-center's Keyboard settings. The descriptions come from mutter data files.
Comment 6 Jonas Ådahl 2018-01-24 11:20:22 UTC
Moving then, as "can't read the text" is a UI issue. Improving strings seems like something separate.
Comment 7 Bastien Nocera 2018-01-24 11:27:16 UTC
(In reply to Jonas Ådahl from comment #6)
> Moving then, as "can't read the text" is a UI issue. Improving strings seems
> like something separate.

And it's what we're asking you to look at. Comment 2.
Comment 8 Jonas Ådahl 2018-01-24 12:02:49 UTC
(In reply to Bastien Nocera from comment #7)
> (In reply to Jonas Ådahl from comment #6)
> > Moving then, as "can't read the text" is a UI issue. Improving strings seems
> > like something separate.
> 
> And it's what we're asking you to look at. Comment 2.

What exactly needs cleaning up and how? I'm not sure how "Move window one workspace to the left" etc can be made much better while staying as informative.
Comment 9 Bastien Nocera 2018-01-24 12:11:36 UTC
(In reply to Jonas Ådahl from comment #8)
> (In reply to Bastien Nocera from comment #7)
> > (In reply to Jonas Ådahl from comment #6)
> > > Moving then, as "can't read the text" is a UI issue. Improving strings seems
> > > like something separate.
> > 
> > And it's what we're asking you to look at. Comment 2.
> 
> What exactly needs cleaning up and how? I'm not sure how "Move window one
> workspace to the left" etc can be made much better while staying as
> informative.

Those files are only used by gnome-control-center nowadays, which is built to run with gnome-shell. Maybe we should move those files to gnome-control-center, and remove mentioned of left and right workspaces, for example.
Comment 10 Georges Basile Stavracas Neto 2018-01-24 13:15:24 UTC
Doesn't the new Keyboard panel layout fix that? None of the strings are ellipsized anymore.
Comment 11 Bastien Nocera 2018-01-24 13:21:21 UTC
(In reply to Georges Basile Stavracas Neto from comment #10)
> Doesn't the new Keyboard panel layout fix that? None of the strings are
> ellipsized anymore.

Is that the case in all the languages, with the font sizes we offer in the a11y panel?
Comment 12 Georges Basile Stavracas Neto 2018-01-24 13:25:07 UTC
Created attachment 367376 [details]
keyboard panel wrapping labels

Yes. See the attached image for exaple; it's Brazilian Portuguese, with many long strings - and the labels wrap and keep readable with different screen sizes.
Comment 13 Georges Basile Stavracas Neto 2018-01-24 13:25:30 UTC
Oh, and with the Large Font a11y settings on.
Comment 14 Bastien Nocera 2018-01-24 13:26:55 UTC
Goodie. Then we just need to see whether all the key definitions provided by mutter have a use in gnome-shell.
Comment 15 Florian Müllner 2018-01-24 16:09:45 UTC
Created attachment 367385 [details] [review]
data: Don't expose horizontal workspace keybindings to Settings

Given that GNOME has used a vertical workspace layout ever since 3.0,
allowing users to assign keyboard shortcuts for horizontal workspace
navigation isn't useful at all, as rightfully pointed out by Bastien
Nocera.


(In reply to Bastien Nocera from comment #14)
> Goodie. Then we just need to see whether all the key definitions provided by
> mutter have a use in gnome-shell.

The attached patch removes the most obvious ones. IMHO we can (and should) do some more cleanups, even though they may end up being more controversal.
Comment 16 Florian Müllner 2018-01-24 16:44:51 UTC
Created attachment 367391 [details] [review]
data: Don't expose window shading shortcut

GTK+ doesn't support shading of client-side decorated windows, and likely
never will (not least because shading is conceptually questionable if the
app customizes the titlebar), and neither do other CSD implementations like
Chromium's. A shortcut that only works with a decreasing number of windows
is more confusing than helpful, so don't expose it.

(In reply to Florian Müllner from comment #15)
> IMHO we can (and should) do some more cleanups, even though they may
> end up being more controversal.

Or not: This one should be fairly straight-forward as well. I was actually misremembering support for partial maximization (bug 746273, but shortcuts aren't affected), so I was going to propose removing those as well for the same reason as above (plus some overlap with tiling).

But considering that they work and have their fan base, I now suggest we keep them.

Finally there are "raise" and "lower" which are currently broken in wayland, but I would expect some protocol to fix that eventually (please correct me if I'm wrong, Jonas).
Comment 17 Florian Müllner 2018-01-24 18:13:15 UTC
To celebrate the move to gitlab, I also created a MR with those changes:
https://gitlab.gnome.org/GNOME/mutter/merge_requests/1
Comment 18 Jonas Ådahl 2018-01-25 01:19:06 UTC
What about moving them to gnome-control-center? Mutter still supports the unlisted keybindings, it's just the UI strings that you removed, but mutter doesn't provide that UI so it shouldn't have the strings. The exact same strings also seem to be available in the gsettings schema as well, why not have g-c-c just have a white-list of what to list, then pick the strings from the schema?
Comment 19 Bastien Nocera 2018-01-25 08:53:37 UTC
Comment on attachment 367391 [details] [review]
data: Don't expose window shading shortcut

Committed as 32547d2eff23bcbfed58edcd22d0fc78c354d923
Comment 20 Florian Müllner 2018-01-25 10:00:43 UTC
Comment on attachment 367385 [details] [review]
data: Don't expose horizontal workspace keybindings to Settings

Attachment 367385 [details] pushed as dc37ee2 - data: Don't expose horizontal workspace keybindings to Settings
Comment 21 André Klapper 2020-11-13 16:37:23 UTC
I don't see a way to reproduce this in 3.38 in Settings' Keyboard Shortcuts (tried with German and Italian).