GNOME Bugzilla – Bug 645444
[PATCH] improve desktop file (categories, scheme handler)
Last modified: 2011-03-22 12:11:26 UTC
Created attachment 183981 [details] balsa-mail-handler.patch To enable balsa as a GNOME mailto scheme handler, desktop file needs additional item. Due to required argument, separate desktop file is required. The patch adds it together with improvement of Categories: Balsa compiled without GNOME will be GTK, with GNOME will be GNOME;GTK, and standard additional text items. Patch requires these actions before applying: mv balsa.desktop.in balsa.desktop.in.in cp -a balsa.desktop.in.in balsa-mailto-handler.desktop.in.in Note that I was not able to verify "make distcheck" due to unrelated problem in balsa-2.4.9: make[1]: Entering directory `/usr/src/packages/BUILD/balsa-2.4.9/src' make[1]: *** No rule to make target `Balsa.idl', needed by `distdir'. Stop. make[1]: Leaving directory `/usr/src/packages/BUILD/balsa-2.4.9/src' Note: Placing any extradist/distclean files inside conditional expression is always a bad idea - you want to have always the same tarball, not depending on configure options (even with specifying discheck configure options it is not the smartest way to do it.
Thank you for your patch - it has been merged! Re distcheck issue: it has been fixed as well by following change to src/Makefile.am diff --git a/src/Makefile.am b/src/Makefile.am index 54b241f..26c7730 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -98,9 +98,6 @@ balsa_gtkspell_extra = \ spell-check.h endif -if BUILD_WITH_UNIQUE -balsa_bonobo_extra_dist = balsa-bonobo.c balsa-bonobo.h Balsa.idl -else if BUILD_WITH_GNOME balsa_bonobo_extra = balsa-bonobo.c balsa-bonobo.h balsa_bonobo_extra_dist = Balsa.idl @@ -115,7 +112,8 @@ $(srcdir)/balsa-bonobo.c: Balsa.h idldir = $(datadir)/idl idl_DATA = Balsa.idl -endif +else +balsa_bonobo_extra_dist = balsa-bonobo.c balsa-bonobo.h Balsa.idl endif balsa_SOURCES = \
FYI. the scheme handler integration was initially reported bug 641949. Balsa required two separate desktop files, as "balsa -m" and balsa "balsa %U" dont't do anything useful. If balsa is able to display arbitrary .eml or .mbox file, then it would require more desktop file changes.