After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645405 - themingengine: don't hardcode white to draw insensitive labels shadow
themingengine: don't hardcode white to draw insensitive labels shadow
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-03-21 14:57 UTC by Cosimo Cecchi
Modified: 2011-03-21 15:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
themingengine: don't hardcode white to draw insensitive labels shadow (1.20 KB, patch)
2011-03-21 14:57 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2011-03-21 14:57:16 UTC 
The dark theme doesn't play nice with GtkThemingEngine hardcoding full white here.
Comment 1 Cosimo Cecchi 2011-03-21 14:57:18 UTC 
Created attachment 183943 [details] [review]
themingengine: don't hardcode white to draw insensitive labels shadow

Use the background color instead.
I think the optimal solution would be delegating the shadow rendering to
the theme completely, and removing this in GtkThemingEngine, but for
now, this simple fix makes the dark variant more usable.
Comment 2 Cosimo Cecchi 2011-03-21 15:00:22 UTC 
Attachment 183943 [details] pushed as 0032b1e - themingengine: don't hardcode white to draw insensitive labels shadow