After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645281 - Package installer needs desktop file
Package installer needs desktop file
Status: RESOLVED FIXED
Product: gnome-packagekit
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-packagekit-maint
gnome-packagekit-maint
[gnome3-important]
Depends on:
Blocks:
 
 
Reported: 2011-03-20 05:02 UTC by William Jon McCann
Modified: 2011-03-25 18:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (69.43 KB, image/png)
2011-03-20 05:03 UTC, William Jon McCann 		  Details
Don't use hardcoded paths to executables (1.35 KB, patch)
2011-03-22 14:56 UTC, William Jon McCann 		accepted-commit_now Details | Review
Use a proper application name (2.91 KB, patch)
2011-03-22 14:56 UTC, William Jon McCann 		none Details | Review
Add desktop file for gpk-dbus-service (1.62 KB, patch)
2011-03-22 14:57 UTC, William Jon McCann 		none Details | Review
Rename to Software Install (803 bytes, patch)
2011-03-22 14:57 UTC, William Jon McCann 		none Details | Review
Rename to Software Install (776 bytes, patch)
2011-03-22 14:57 UTC, William Jon McCann 		none Details | Review
Use a proper application name (2.91 KB, patch)
2011-03-22 15:09 UTC, William Jon McCann 		none Details | Review

Description William Jon McCann 2011-03-20 05:02:55 UTC 
When clicking on an RPM I get what you see in the attached shot.  We need to attach a name to this process.  Currently it is gpk-dbus-service based on the WM_CLASS.

"Package Installer" or something would do.
Comment 1 William Jon McCann 2011-03-20 05:03:20 UTC 
Created attachment 183839 [details]
screenshot
Comment 2 William Jon McCann 2011-03-20 05:04:48 UTC 
or "Software Installer"
Comment 3 Richard Hughes 2011-03-20 08:01:45 UTC 
gpk-dbus-service is autostarted by DBus. I'll have a look at this on Monday.
Comment 4 Richard Hughes 2011-03-21 18:51:03 UTC 
I've merged this today:

commit 01cfa53f978af5000a7e49a79ad2210e9186cfee
Author: Richard Hughes <richard@hughsie.com>
Date:   Mon Mar 21 16:54:59 2011 +0000

    Rename the desktop file to match the executable name

I'm not sure how gnome-shell / mutter does the executable -> desktop mapping, but now at least the desktop filename matches the binary name.

Can you retry with this please. Thanks.
Comment 5 William Jon McCann 2011-03-21 19:05:37 UTC 
Ok rebuilding now.  Will retry in a sec.  http://live.gnome.org/ThreePointZero/AppIntegration has some info.  Basically I think your WM_CLASS has to match the desktop file name.
Comment 6 William Jon McCann 2011-03-22 14:56:55 UTC 
Created attachment 184073 [details] [review]
Don't use hardcoded paths to executables

They may be installed to a different prefix.
Comment 7 William Jon McCann 2011-03-22 14:56:58 UTC 
Created attachment 184074 [details] [review]
Use a proper application name
Comment 8 William Jon McCann 2011-03-22 14:57:00 UTC 
Created attachment 184075 [details] [review]
Add desktop file for gpk-dbus-service

Provides app name and icon for dialogs presented by the service.
Comment 9 William Jon McCann 2011-03-22 14:57:03 UTC 
Created attachment 184076 [details] [review]
Rename to Software Install

To be consistent with the other names.
Comment 10 William Jon McCann 2011-03-22 14:57:06 UTC 
Created attachment 184077 [details] [review]
Rename to Software Install

To be consistent with the other names
Comment 11 Colin Walters 2011-03-22 14:58:47 UTC 
Review of attachment 184074 [details] [review]:

::: src/gpk-install-package-name.c
@@ +65,2 @@
 	/* TRANSLATORS: program name: installs a package (or packages) by name */
+	g_set_application_name (_("Sofware Install"));

Typo, Software
Comment 12 William Jon McCann 2011-03-22 15:09:31 UTC 
Created attachment 184080 [details] [review]
Use a proper application name
Comment 13 Richard Hughes 2011-03-22 15:35:18 UTC 
Review of attachment 184073 [details] [review]:

This patch looks good, thanks. Can you please email the release team asking for a hard-code break please.
Comment 14 Richard Hughes 2011-03-22 15:36:45 UTC 
I don't think we can apply the other patches as they are breaking string freeze, and we're already in hard code freeze. I think they are fine for master but not for gnome-3-0.
Comment 15 William Jon McCann 2011-03-22 15:56:10 UTC 
We need at least some of them.
Comment 16 William Jon McCann 2011-03-22 19:27:14 UTC 
I've requested approval for a freeze break.