After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645267 - build: fix build with -Werror with GCC 4.6.0
build: fix build with -Werror with GCC 4.6.0
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal blocker
: 0.10.33
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-19 22:29 UTC by Jason Clinton
Modified: 2011-03-21 08:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
build: fix build with -Werror with GCC 4.6.0 (2.60 KB, patch)
2011-03-19 22:29 UTC, Jason Clinton 		committed Details | Review

Description Jason Clinton 2011-03-19 22:29:05 UTC 
Because -Werror is the default, this breaks the build of gstreamer. Setting to
critical.

I will override -Werror in the jhbuild modulesets until this is fixed.

Really not sure that the third chunk's loop was of any value before this patch
and it certainly may not be after this patch. (Optimizations, etc, etc.) Not
sure that it really matters.
Comment 1 Jason Clinton 2011-03-19 22:29:07 UTC 
Created attachment 183824 [details] [review]
build: fix build with -Werror with GCC 4.6.0

This touches three areas of code, removes unused variables and discards
return values from two functions with (void).
Comment 2 Tim-Philipp Müller 2011-03-19 23:13:27 UTC 
Thanks for the patch.

-Werror is only used when building git. You can use

  make ERROR_CFLAGS=''

to build without -Werror.
Comment 3 Sebastian Dröge (slomo) 2011-03-21 08:30:29 UTC 
commit a789096c04a661cf34df833be8ee927388aa12de
Author: Jason D. Clinton <me@jasonclinton.com>
Date:   Sat Mar 19 17:06:12 2011 -0500

    build: fix build with -Werror with GCC 4.6.0
    
    This touches three areas of code, removes unused variables and discards
    return values from two functions with (void).
    
    https://bugzilla.gnome.org/show_bug.cgi?id=645267