GNOME Bugzilla – Bug 645121
Contact Search uses Ctrl-F, leaving Find in Contact List
Last modified: 2011-03-21 00:00:59 UTC
I noticed today that hitting Control-F in the contact list opens the contact search dialog, and that there's no keyboard shortcut for searching within the contact list. Although you can start searching by typing, I would expect Control-F to explicitly search within the contact list, and some other shortcut to show me a way to search an online directory: Shift-Control-F, maybe. The HIG, happily, backs me up: Find... Ctrl+F Find matches in the current document, highlighting them in-place Search... Ctrl+F (see note below) Search for matches in multiple documents, files or other external sources If your application requires both Edit ▸ Find and Edit ▸ Search menu items, use Shift+Ctrl+F as the shortcut for Search. — <http://library.gnome.org/devel/hig-book/2.32/input-keyboard.html.en#standard-shortcuts> I think searching within the contact list matches the first, and searching online directories matches the second.
Created attachment 183706 [details] [review] Map Ctrl-Shift-F to contact search and Ctrl-F to find As discussed on <https://bugzilla.gnome.org/show_bug.cgi?id=645121>, currently Ctrl-F opens the contact search dialog, and there's no keyboard shortcut for searching within the contact list (other than just typing). The Gnome HIG handles this situation: it says that the former should be Ctrl-Shift-F and the latter should be Ctrl-F. <http://library.gnome.org/devel/hig-book/2.32/input-keyboard.html.en#standard-shortcuts>
Thanks for the patch. I merged it to master and pushed a simplified version to 2.34: commit 5f6fc105b14d1cb84745e2f60991a9010d10914b Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Fri Mar 18 14:55:59 2011 +0100 Set an accelator on contact search This is kinda based on Will's 87fe6f3680d91edc933bc767cae6e500b8bac011 patch changing the accelator but 2.34 doesn't have the menu entry, and so the accelator, for live search so I just picked this part from it. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Created attachment 183878 [details] [review] Add an eMusic web store pane. This is basically copy-pasta from the Amazon store, and uses the existing eMusic downloader plugin. It's lacking an icon, and doesn't detect being logged in or out.
Created attachment 183879 [details] [review] eMusic Store: Add a Signout link. This works a little differently to the Amazon version: because we don't have any other items in the menu, just hiding the item leaves us with an empty menu in the UI. If a similar page is added for eMusic, this could be made to work like Amazon.
Created attachment 183880 [details] [review] Amazon: fix signed-in detection for UK store.
sorry, i'm an idiot.