After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645116 - activities hot corner present on all monitors
activities hot corner present on all monitors
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 645023
 
 
Reported: 2011-03-18 10:43 UTC by Jussi Kukkonen
Modified: 2011-03-21 09:43 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Only add hot corner for primary and "top left" monitors (4.13 KB, patch)
2011-03-18 13:23 UTC, Alexander Larsson
committed Details | Review

Description Jussi Kukkonen 2011-03-18 10:43:22 UTC
In a dual screen setup the non-primary monitors (without the panel) also have a hot corner. This leads to activities mode unexpectedly opening when cursor moves over the corner (which can easily happen when moving cursor from the non-primary monitor on the right to the panel on the primary monitor on the left).
Comment 1 Alexander Larsson 2011-03-18 12:02:08 UTC
Hmm. I can see how that could trigger, although you have to be kinda lucky (or slow) to end up at the right pixel.

I'm adding pointer barriers to the panel, so that it will be easy to hit the corners on the primary monitor. However, i don't think we want to add barriers in each monitor corner, for instance that would make it hard to enter the primary monitor.

I think we should only add hot corners on monitors that have a natural top-left corner, like the leftmost monitor, or a non-primary monitor in a layout like:


corner -> +-------------
          |            |
+---------+            |
|=========|            |
|         |            |
|         |            |
|         |            |
+---------+------------+
Comment 2 Jussi Kukkonen 2011-03-18 12:42:12 UTC
I was aiming for the status/session-applet and happened to slow the movement down just a bit early. For reference the setup was like this:

          unexpected hot corner
          ↓
+---------+-------+
|=========|       |
|         |       |
|         +-------+
+---------+


Your solution sounds good.
Comment 3 Alexander Larsson 2011-03-18 13:23:47 UTC
Created attachment 183712 [details] [review]
Only add hot corner for primary and "top left" monitors

To avoid having hot corners that accidentally trigger when e.g. trying
to hit the panel on the primary monitor we add hot corners only to
monitors that are "naturally" top left (top right for RTL).

For instance, we'd like a hot corner here:

corner -> +-------------
          |            |
+---------+            |
|=========|            |
|         |            |
|         |            |
|         |            |
+---------+------------+

But not here:

          unexpected hot corner
          ↓
+---------+-------+
|=========|       |
|         |       |
|         +-------+
+---------+
Comment 4 Owen Taylor 2011-03-19 19:07:34 UTC
Review of attachment 183712 [details] [review]:

Seems probably right to me, especially since we won't have barriers on a lot of sstems for GNOME 3. I think we haven't really solved the question of how you use the overview in a multihead configuration - if you have to mouse across two monitors to get to the overview (or interact with it after bringing it up with a hot key) that's pretty hard. Maybe it will make sense to have hotcorners on each monitor and bring up the overview on the monitor where you activate it.

Patch looks good to commit, except for one small style point.

::: js/ui/main.js
@@ +502,3 @@
+
+
+        let haveTopLeftCorner = true;

This naming is sort of confusing, but don't have a suggestion otherwise, so OK.

@@ +509,3 @@
+        if (St.Widget.get_default_direction() == St.TextDirection.RTL) {
+            besideX = monitor.x + 1;
+        }

Excess {}, generally would prefer if this was written symetrically instead of overwriting the LTR case with the RTL case.
Comment 5 Alexander Larsson 2011-03-21 09:43:48 UTC
Attachment 183712 [details] pushed as 70ae700 - Only add hot corner for primary and "top left" monitors