GNOME Bugzilla – Bug 645031
Warnings when removing workspaces
Last modified: 2011-06-03 17:58:31 UTC
When workspaces are removed i get warnings like: Window manager warning: Log level 16: value "-nan" of type `gfloat' is invalid or out of range for property `y' of type `gfloat' This is due to this code in workspacesView.js:_updateWorkspaceActors() Tweener.addTween(workspace.actor, { y: workspace.x, Its obviously wrong to tween y to x, but neither workspace.x or workspace.y is set. I don't know what the initial code was supposed to do here. Where do we want to animate lost workspaces to?
Well, they already do animate, out off the right side, the opposite of the animating-in effect. Maybe this part is just dead code?
Created attachment 188985 [details] [review] workspaces-view: Simplify handling of removed workspaces (In reply to comment #0) > This is due to this code in workspacesView.js:_updateWorkspaceActors() > > Tweener.addTween(workspace.actor, > { y: workspace.x, > > Its obviously wrong to tween y to x, but neither workspace.x or workspace.y is > set. Woops, looks like it should now be workspace._y, but ... > I don't know what the initial code was supposed to do here. Where do we > want to animate lost workspaces to? ... the animation is completely unnecessary now - Dan is right, it's pretty much dead code (e.g. animating an empty container). Workspaces used to contain the desktop background, so when a workspace was removed, we animated its actor to an off-screen position before destroying it. As the background has been removed a while ago, we can destroy the actor directly.
Comment on attachment 188985 [details] [review] workspaces-view: Simplify handling of removed workspaces This all looks reasonable, but if I repeatedly do the "drag last window from existing workspace to a new workspace" thing, I still get Window manager warning: Log level 16: value "-84.957748" of type `gfloat' is invalid or out of range for property `width' of type `gfloat' etc
(In reply to comment #3) > (From update of attachment 188985 [details] [review]) > This all looks reasonable, but if I repeatedly do the "drag last window from > existing workspace to a new workspace" thing, I still get > > Window manager warning: Log level 16: value "-84.957748" of type `gfloat' > is invalid or out of range for property `width' of type `gfloat' > > etc Looks like bug 649001?
Comment on attachment 188985 [details] [review] workspaces-view: Simplify handling of removed workspaces ok, 649001 fixes the warnings, and this patch doesn't seem to change any behavior, so I guess it's correct.
Attachment 188985 [details] pushed as 45c1a9e - workspaces-view: Simplify handling of removed workspaces