After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 645011 - multiudpsink does not support setting a socket interface
multiudpsink does not support setting a socket interface
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.x
Other Linux
: Normal enhancement
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-17 11:35 UTC by ludovica
Modified: 2014-11-28 20:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to add an interface_ipv4 prop to multiudpsink (3.92 KB, patch)
2011-03-17 11:35 UTC, ludovica
needs-work Details | Review

Description ludovica 2011-03-17 11:35:53 UTC
Created attachment 183620 [details] [review]
Patch to add an interface_ipv4 prop to multiudpsink

Multiudpsink creates a socket through which the multicast traffic is sent. The interface used is automatically the default system interface.

This patch introduces a new property called interface_ipv4. If set, the ipv4 address specified becomes the origin of the multicast traffic (using the setsockopt option IP_MULTICAST_IF, and if the address is a valid interface).

I looked carefully at ipv4 vs. ipv6. However the behavior of setsockopt doesn't seem to be consistent when it comes to checking the socket family and the data given. This is why I explicitely call this prop "_ipv4".

I attach a patch for this feature.
Comment 1 David Schleef 2011-06-30 04:32:19 UTC
Confirmed that this is a valid requirement.  Did not look at the patch.

IMO, calling the property "interface" is fine.  We can just give a warning for ipv6.
Comment 2 Holger Kaelberer 2012-04-25 15:31:52 UTC
ping <maintainer>

We use this patch, it works and is really useful ;-)

Is there still something needed to push this upstream?
Comment 3 Sebastian Dröge (slomo) 2013-11-01 15:56:40 UTC
Comment on attachment 183620 [details] [review]
Patch to add an interface_ipv4 prop to multiudpsink

This needs to be ported to 1.0 first. I think it's useful, but isn't there something else that can be used for IPv6 too?

For the source there's API to select an interface by its name.
Comment 4 Tim-Philipp Müller 2014-11-28 20:59:49 UTC
I think this was fixed by

commit 11ed7c037329f71be337669f3e4b27b550ebf713
Author: Rasmus Rohde <rohde@duff.dk>
Date:   Wed Oct 10 10:55:28 2012 +0200

    multiudpsink: add multicast-iface property
    
    udpsrc already has support for setting the multicast interface, which
    is useful for multi-homed machines. This patch adds the same code to
    the multiudpsink.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=685864