After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644976 - Fix "backspace", "enter", "escape" input.
Fix "backspace", "enter", "escape" input.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-03-17 00:09 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2011-03-17 00:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdkkeyuni: Fix DEL for binary search (931 bytes, patch)
2011-03-17 00:09 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review
Don't only use ch != 0 to check if a character is a control char. (1.26 KB, patch)
2011-03-17 00:09 UTC, Jasper St. Pierre (not reading bugmail)
committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2011-03-17 00:09:07 UTC
66a77d0bc0cadcf14faeb3d6a5da3a78ae1ab6d1 broke GTK+'s IM stuff.
Fix it.
Comment 1 Jasper St. Pierre (not reading bugmail) 2011-03-17 00:09:10 UTC
Created attachment 183593 [details] [review]
gdkkeyuni: Fix DEL for binary search

The list needs to be sorted in order for the binary search to work properly.
Comment 2 Jasper St. Pierre (not reading bugmail) 2011-03-17 00:09:13 UTC
Created attachment 183594 [details] [review]
Don't only use ch != 0 to check if a character is a control char.
Comment 3 Matthias Clasen 2011-03-17 00:11:02 UTC
Thanks, both look good to me. Please commit to master and gtk-3-0
Comment 4 Jasper St. Pierre (not reading bugmail) 2011-03-17 00:13:04 UTC
Attachment 183593 [details] pushed as 6ecfddf - gdkkeyuni: Fix DEL for binary search
Attachment 183594 [details] pushed as ff9eb56 - Don't only use ch != 0 to check if a character is a control char.