After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644975 - styleproperties: make sure to merge the font descriptions right
styleproperties: make sure to merge the font descriptions right
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-03-17 00:00 UTC by Cosimo Cecchi
Modified: 2011-03-17 18:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
styleproperties: make sure to merge the font descriptions right (1.07 KB, patch)
2011-03-17 00:00 UTC, Cosimo Cecchi
none Details | Review
styleproperties: make sure to merge the font descriptions right (2.01 KB, patch)
2011-03-17 14:54 UTC, Cosimo Cecchi
none Details | Review
styleproperties: make sure to merge the font descriptions right (1.82 KB, patch)
2011-03-17 18:24 UTC, Cosimo Cecchi
none Details | Review

Description Cosimo Cecchi 2011-03-17 00:00:48 UTC
The pango_font_description_merge() call was doing the opposite, so it was never possible to override the widget font.
Comment 1 Cosimo Cecchi 2011-03-17 00:00:55 UTC
Created attachment 183591 [details] [review]
styleproperties: make sure to merge the font descriptions right
Comment 2 Cosimo Cecchi 2011-03-17 14:54:47 UTC
Created attachment 183635 [details] [review]
styleproperties: make sure to merge the font descriptions right

Improved patch
Comment 3 Cosimo Cecchi 2011-03-17 18:24:32 UTC
Created attachment 183663 [details] [review]
styleproperties: make sure to merge the font descriptions right

Correct patch this time.
Comment 4 Cosimo Cecchi 2011-03-17 18:37:01 UTC
Pushed a proper fix to master and 3-0 after talking with Carlos on IRC.