GNOME Bugzilla – Bug 644908
add "PULSE_PROP_media.role" to gnome-sound-recorder
Last modified: 2012-06-06 14:54:48 UTC
The sound recorder needs to set its role inside PulseAudio so that the volume UIs can set the record level for the application (as stated in http://pulseaudio.org/wiki/ApplicationProperties). Attached patch sets the value for the PULSE_PROP_media.role environment variable
Created attachment 183533 [details] [review] The patch
initial report: https://bugs.launchpad.net/ubuntu/+source/gnome-media/+bug/736042
Created attachment 215732 [details] [review] grecord: add "PULSE_PROP_media.role" Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
Review of attachment 215732 [details] [review]: ::: grecord/src/gnome-recorder.c @@ +194,1 @@ please follow the project / GNOME coding style, add missing space before parenthesis.
Review of attachment 215732 [details] [review]: also the patch author should be Rodrigo Moya <rodrigo@gnome-db.org>, since he wrote it.
hmm, apparently you are actually the author of the patch, if I follow launchpad. Btw, what does that solve exactly? I see a problem there because, the recorder streams can be both playback & recording and I am not sure they should be the same role.
Created attachment 215739 [details] screenshot Easies way to explain is to show :) To notify volume applet to show recording level control, we need to set some role: phone or production. And second reason is, phone role allowed to mute all other roles but not production.
Created attachment 215740 [details] [review] grecord: add "PULSE_PROP_media.role" v2: add missing space before parenthesis Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
(In reply to comment #7) > To notify volume applet to show recording level control, we need to set some > role: phone or production. > > And second reason is, phone role allowed to mute all other roles but not > production. Right, but what about playback stream? Should it be tagged as production role too?
According to: http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/Developer/Clients/ApplicationProperties ... "video": for movie/video streams from media players "music": for music streams from media players "game": for audio from games "event": for event sounds (i.e. button clicks, ...) "phone": for phone data (i.e. voip speech audio) "animation": for animations (i.e. Flash) "production": for audio production applications. "a11y": accessibility applications (i.e. screen readers, ...) ... grecord is production application, independent of playback or record.
Review of attachment 215740 [details] [review]: ack thanks for the pointer (that link could also be in the commit message)
Comment on attachment 215740 [details] [review] grecord: add "PULSE_PROP_media.role" Attachment 215740 [details] pushed as 5453719 - grecord: add "PULSE_PROP_media.role"
you will need to close this bug. I do not have rights for this.