After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644907 - [0.11] Add support for blocking sinkpads in push mode
[0.11] Add support for blocking sinkpads in push mode
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal enhancement
: 0.11.x
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-16 10:46 UTC by Sebastian Dröge (slomo)
Modified: 2011-11-08 12:48 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Sebastian Dröge (slomo) 2011-03-16 10:46:07 UTC 
Currently sinkpads can only be blocked in pull mode and no block handler is called in push mode for them. We can't change this for 0.10 because the reason was this was that you can install pad blocks on both pads now and depending on the scheduling mode only one pad block handler is called and you can do whatever you wanted from there.

For consistency the same change should be done for srcpads. Currently they can only be blocked in push mode for the above reason.
Comment 1 Wim Taymans 2011-11-04 17:50:37 UTC 
commit b6fbeb8fedaabe8768ae390edcc0099ba7750514
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Nov 4 18:19:14 2011 +0100

    pad: make probes work on all pads
    
    fixes #644907
Comment 2 Wim Taymans 2011-11-04 17:52:07 UTC 
this has some complications, because putting a pad probe on a srcpad will now also block upstream events to that pad. This means that in the callback you might want to let those pass to avoid deadlocks.

Another option that I think is good to have is to make some more block flags to only block on UPSTREAM or DOWNSTREAM traffic. I will do that next if nothing else comes up.
Comment 3 Wim Taymans 2011-11-08 12:48:58 UTC 
Should all be fixed now.