After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644866 - Default modifier to edit panel doesn't work
Default modifier to edit panel doesn't work
Status: RESOLVED OBSOLETE
Product: gnome-panel
Classification: Other
Component: libpanel-applet
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 644603 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-03-15 23:28 UTC by Krzysztof Kotlenga
Modified: 2015-03-24 14:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
panel, libpanel-applet: Correctly test for modifier keys (8.56 KB, patch)
2011-04-13 13:34 UTC, Vincent Untz
committed Details | Review

Description Krzysztof Kotlenga 2011-03-15 23:28:05 UTC
gnome-panel doesn't fall back to any reasonable modifier key if /apps/metacity/general/mouse_button_modifier gconf key isn't present. In the result, panels can't be edited. This can happen if one doesn't have metacity installed and uses another window manager instead.

Related console output:

(gnome-panel:1274): Gtk-CRITICAL **: gtk_accelerator_parse: assertion `accelerator != NULL' failed

** (gnome-panel:1274): WARNING **: Unable to parse mouse modifier '(null)'


I guess it should fall back to <Alt> in this case.

BTW, there might be another bug lying somewhere close, because even with metacity schema installed <Alt> doesn't work for me. I had to change mouse_button_modifier to <Ctrl> to get it working.
Comment 1 Vincent Untz 2011-03-22 16:45:04 UTC
If metacity is not installed, the default is still <Alt>, as in GDK_MOD1_MASK: "the fourth modifier key (it depends on the modifier mapping of the X server which key is interpreted as this modifier, but normally it is the Alt key)".

Do you know what is MOD1 for you?
Comment 2 Krzysztof Kotlenga 2011-03-22 18:53:42 UTC
Oops, sorry for the mistake about the missing schema.
MOD1 is Alt_L.

xmodmap says:
mod1        Alt_L (0x40),  Meta_L (0xcd)
Comment 3 Vincent Untz 2011-04-13 13:34:38 UTC
Created attachment 185866 [details] [review]
panel, libpanel-applet: Correctly test for modifier keys

Using Alt to edit the panels doesn't always work; this is likely because
we were not using gtk_accelerator_get_default_mod_mask() to test the
modifier key.

Note that we double-check that the metacity modifier is in the mask
returned by gtk_accelerator_get_default_mod_mask(), to make sure it
always work -- if it's not there, we default to MOD1.
Comment 4 Vincent Untz 2011-04-13 13:34:59 UTC
Could you see if this patch helps?
Comment 5 Vincent Untz 2011-04-13 13:35:20 UTC
*** Bug 644603 has been marked as a duplicate of this bug. ***
Comment 6 Christoph Brill 2011-04-13 13:59:20 UTC
This patch does not seem to change anything on my system. Next to that I have '<Alt>' set as /apps/metacity/general/mouse_button_modifier and don't get the message mentioned in the first comment.

My complete configure options (in case it matters):

./configure --prefix=/usr --build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu --mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share --sysconfdir=/etc --localstatedir=/var/lib --libdir=/usr/lib64 --disable-deprecation-flags --disable-static --disable-scrollkeeper --disable-schemas-install --disable-schemas-compile --with-in-process-applets=clock,notification-area,wncklet --enable-telepathy-glib --enable-network-manager --enable-introspection --enable-eds --disable-gtk-doc
Comment 7 Krzysztof Kotlenga 2011-04-13 15:49:23 UTC
This patch doesn't work for me either.
Comment 8 Akhil Laddha 2011-04-27 05:30:11 UTC
Changing needinfo status as information has been provided.
Comment 9 Alberts Muktupāvels 2013-11-22 12:47:16 UTC
Review of attachment 185866 [details] [review]:

Checked code and seems that this patch has been committed.