GNOME Bugzilla – Bug 644730
[matroskamux] Should return TRUE in the event function when the event is handled
Last modified: 2011-03-14 17:10:38 UTC
It should return TRUE in the event function when the event is handled
Created attachment 183346 [details] [review] 0001-matroskamux-fix-return-value-in-the-event-function-w.patch And set the event to NULL as a hint to chain up
Comment on attachment 183346 [details] [review] 0001-matroskamux-fix-return-value-in-the-event-function-w.patch What we want to achieve (aiui): current behaviour is maintained, only that we return TRUE for tag events that are not forwarded, because it's been handled. It looks to me like your patch changes behaviour so that the tag event is now forwarded (if it doesn't crash before that). "if (ret) chain->up()" should be changed to "if (event) chain->up()". event should also be set to NULL in the newsegment part then.
Created attachment 183352 [details] [review] 0001-matroskamux-fix-return-value-in-the-event-function-w.patch You are right. Changed to check "if (event)" an setting "event=NULL" for the NEWSEGMENT .
upps wrong file
Created attachment 183353 [details] [review] 0001-matroskamux-fix-return-value-in-the-event-function-w.patch
commit 0ed0174ea98923186112458512e5a026ac69716c Author: Andoni Morales Alastruey <amorales@flumotion.com> Date: Mon Mar 14 15:46:50 2011 +0100 matroskamux: return TRUE from sink pad event function for tag events, which are handled https://bugzilla.gnome.org/show_bug.cgi?id=644730