After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644591 - Use GNOME Session DBus in the status menu
Use GNOME Session DBus in the status menu
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-12 20:37 UTC by Giovanni Campagna
Modified: 2011-03-13 17:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Status Menu: use Gnome Session DBus for shutdown and logout (2.52 KB, patch)
2011-03-12 20:37 UTC, Giovanni Campagna 		committed Details | Review

Description Giovanni Campagna 2011-03-12 20:37:17 UTC 
Using gnome-session-quit is not compatible with 2.32, making it impossible to power off and log out in older systems. Since the DBus interface did not change, we can use that instead.
Comment 1 Giovanni Campagna 2011-03-12 20:37:40 UTC 
Created attachment 183238 [details] [review]
Status Menu: use Gnome Session DBus for shutdown and logout

Around 2.91.90, gnome-session-save was renamed to gnome-session-quit.
This commit restores compatibility with the older gnome-session, for
those testing under GNOME 2.32 or below, by calling the DBus methods
directly.
Comment 2 Frederic Peters 2011-03-12 21:35:03 UTC 
fwiw I added a patch with a similar purpose to the debian package, but I did differently, simply falling back on gnome-session-save if gnome-session-quit fails.

http://svn.debian.org/viewsvn/pkg-gnome/packages/experimental/gnome-shell/debian/patches/04_gnome_session_quit.patch?revision=26842&view=markup
Comment 3 drago01 2011-03-12 22:11:40 UTC 
Review of attachment 183238 [details] [review]:

Looks good and using DBUS directly makes sense anyway regardless of 2.32 compatibility.
Comment 4 Giovanni Campagna 2011-03-12 22:48:09 UTC 
Attachment 183238 [details] pushed as 73274e2 - Status Menu: use Gnome Session DBus for shutdown and logout
Comment 5 Colin Walters 2011-03-13 16:46:44 UTC 
(In reply to comment #2)
> fwiw I added a patch with a similar purpose to the debian package,
 
Did you not open a bug here pointing to that patch?  If so, please in the future do so.
Comment 6 Frederic Peters 2011-03-13 17:18:47 UTC 
Sure Colin, I do forward bugs, but that one was created two hours prior to this bug report, and had limited testing as the package is not yet uploaded (and also the patch was wrong as I assumed gnome-session-quit used the same arguments than gnome-session-save).