After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644420 - Delegates: Add support for attributes used by standard methods
Delegates: Add support for attributes used by standard methods
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Delegates
0.11.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2011-03-10 18:24 UTC by Michal Hruby
Modified: 2011-04-05 20:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add-support-for-array_length_type-in-delegate-return (5.36 KB, patch)
2011-03-10 18:24 UTC, Michal Hruby 		committed Details | Review
gidlparser-Add-support-for-array-returns-in-delegate (1.16 KB, patch)
2011-03-10 18:25 UTC, Michal Hruby 		committed Details | Review
gidlparser-Support-delegates-throwing-Errors (2.11 KB, patch)
2011-03-10 18:25 UTC, Michal Hruby 		none Details | Review

Description Michal Hruby 2011-03-10 18:24:47 UTC 
Created attachment 183082 [details] [review]
Add-support-for-array_length_type-in-delegate-return

Attached patch adds support for array_length_type attribute to delegates, as well as copies delegate array properties to the inner method.

Further, gidlparser is extended to support delegates returning arrays, specifying custom array_length_type and throwing Errors.
Comment 1 Michal Hruby 2011-03-10 18:25:10 UTC 
Created attachment 183083 [details] [review]
gidlparser-Add-support-for-array-returns-in-delegate
Comment 2 Michal Hruby 2011-03-10 18:25:34 UTC 
Created attachment 183084 [details] [review]
gidlparser-Support-delegates-throwing-Errors
Comment 3 Luca Bruno 2011-04-04 14:47:19 UTC 
Review of attachment 183082 [details] [review]:

commit b31963e1db2f461858661854c44a21752226054b
Author: Michal Hruby <michal.mhr@gmail.com>
Date:   Wed Mar 9 20:13:27 2011 +0100

    Support array_length_type for delegate return values
    
    Partially fixes bug 644420.
Comment 4 Luca Bruno 2011-04-04 15:28:00 UTC 
Review of attachment 183083 [details] [review]:

commit c3b704038a7874055c2707bd791428a030d18b64
Author: Michal Hruby <michal.mhr@gmail.com>
Date:   Wed Mar 9 20:16:04 2011 +0100

    gidlparser: Add support for array return values in delegates
    
    Partially fixes bug 644420.
Comment 5 Luca Bruno 2011-04-05 20:42:59 UTC 
commit 1df2c050ba29c84026a14e7ee23fa6bcd00b1044
Author: Michal Hruby <michal.mhr@gmail.com>
Date:   Tue Apr 5 22:38:56 2011 +0200

    gidlparser: Support error types for delegates
    
    Fixes bug 644420.