GNOME Bugzilla – Bug 644361
prelight summary-sources
Last modified: 2011-03-22 13:30:47 UTC
After some chatting on IRC with Owen in particular the issue came up that users apparently tend to target the icon as there's no indication that the entire summary-source is click-able. I figured I would address this since it's a fairly prominent and frequently used piece of UI. This relies on Dan's work in bug 630842 to be at its most effective.
Created attachment 183034 [details] [review] Update style for message tray summary-sources Users may have difficulty realizing that the entire summary-source is clickable including the title. In order to clarify this create a border wrapper around each summary-source and "buttonize" it with a background-color. Additionally style source-titles so they match other UI elements in the shell.
Per feedback from jimmac on irc requesting a style more similar to the mockup here: http://git.gnome.org/browse/gnome-shell-design/plain/mockups/static/notifications-music-playback.png I redid this from scratch. A few notes: 1) This still depends on bug 630842 to be most effective. 2) This currently also relies on a change to .summary-source-button to allow the new property/pseudo-class :expanded. Florian said he'd knock out a quick patch for it, in the meantime I've added the hooks in the CSS so it will work once it exists. Patch forthcoming.
Created attachment 183113 [details] [review] Update style for message tray summary-sources Users may have difficulty realizing that the entire summary-source, including the title, is clickable. To clarify this to the user pre-light summary-sources so they match other UI elements in the shell, in particular the panel.
Created attachment 183116 [details] [review] Add source-button-border SVG Previously we were using the same border-image as the panel, but the SVG had more padding than we required which caused the border to not wrap the entire lower portion of summary-sources. Create a new border image just for summary sources and use it.
The glow effect is currently used for selected menu like items. It says that this item is "on". I don't like using that effect for a prelight.
I think we should just do the same as for bug 609576.
So in this case we should change summary-sources to another color normally, say color: #ccc and hover: { color: #fff }, and expanded show the glow effect. But that doesn't necessarily solve the problem of a user not being able to identify that the title is clickable and not just the icon since there wouldn't be any realization of initial feedback. I'll squash something new together though based on your instructions and then fmuellner just has to submit his patch.
Created attachment 183311 [details] [review] Update style for message tray summary-sources Users may have difficulty realizing that the entire summary-source is clickable including the title. In order to clarify this to the user prelight them on hover. Additionally add a style so that when they are expanded the appearance will be similar to that of panel items.
Created attachment 183398 [details] [review] Update-style-for-message-tray-summary-sources Rebased off of master.
Attached a rebase here and to bug 609576. Jon said he had trouble getting it to apply. Not sure why. Anyway just tested git bz apply and it works fine, although I apparently left a whitespace because I'm a jerk.
After talking with Jon we came to the conclusion that this should be split up into multiple patches so changes can be pushed faster. So for now I'll post just the patch which changes the color: of summary-sources in order to prelight them. The styling for the to-be-added :expanded method will be posted in a new bug.
Created attachment 183402 [details] [review] Prelight summary-sources Users may have difficulty realizing that the entire summary-source is clickable including the title. In order to clarify this to the user prelight them on hover.
Created attachment 183473 [details] [review] Prelight-summary-sources Fix author and contact information.
Review of attachment 183473 [details] [review]: Thanks for coming up with these patches! In the interests of time I merged this patch with the one in bug 644788. My one change to it was that I removed keeping the summary item text gray when it is not hovered over because the only time it is visible is when you hover to the left of the left-most item, and I think it is odd and distracting.
Anything left here?
Nope. Marking Resolved due to bug 644788 being committed.