After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644324 - Dash: Start animations when a drag has been cancelled
Dash: Start animations when a drag has been cancelled
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Owen Taylor
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-03-09 16:33 UTC by Florian Müllner
Modified: 2011-03-19 10:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
overview: Handle drag-cancelled signal for items (2.25 KB, patch)
2011-03-09 16:33 UTC, Florian Müllner 		committed Details | Review
workspaces-view: Zoom out early on canceled item drags (2.12 KB, patch)
2011-03-09 16:33 UTC, Florian Müllner 		committed Details | Review
dash: Handle cancelled drags (1.91 KB, patch)
2011-03-09 16:33 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-03-09 16:33:23 UTC 
... rather than waiting for the snapback animation to complete.
Comment 1 Florian Müllner 2011-03-09 16:33:27 UTC 
Created attachment 183003 [details] [review]
overview: Handle drag-cancelled signal for items

Allow handling the drag-cancelled signal for non-window items, just
like the handling for windows instroduced in commit a80e88e33.
Comment 2 Florian Müllner 2011-03-09 16:33:34 UTC 
Created attachment 183004 [details] [review]
workspaces-view: Zoom out early on canceled item drags

Start the zoom at the same time as the snapback animation, as it's
already done for window snapbacks.
Comment 3 Florian Müllner 2011-03-09 16:33:40 UTC 
Created attachment 183005 [details] [review]
dash: Handle cancelled drags

If a drag was cancelled, do animations like size changes or zooming
out the remove target in parallel with the snapback animation.
Comment 4 Owen Taylor 2011-03-18 18:19:49 UTC 
Review of attachment 183003 [details] [review]:

Looks good
Comment 5 Owen Taylor 2011-03-18 18:23:15 UTC 
Review of attachment 183004 [details] [review]:

Look good
Comment 6 Owen Taylor 2011-03-18 18:29:02 UTC 
Review of attachment 183005 [details] [review]:

Looks good
Comment 7 Florian Müllner 2011-03-19 10:16:57 UTC 
Attachment 183003 [details] pushed as 6ae914d - overview: Handle drag-cancelled signal for items
Attachment 183004 [details] pushed as 7f35b2d - workspaces-view: Zoom out early on canceled item drags
Attachment 183005 [details] pushed as 2c48efa - dash: Handle cancelled drags