GNOME Bugzilla – Bug 644313
[regression] Splitting does not work if no clip is selected
Last modified: 2011-04-06 14:08:46 UTC
Splitting is non-modal and when you have a clip selected, it splits only that clip. However, it is *also* intended to work when no clips are selected: when that is the case, splitting will split all clips at the position of the timeline. As such, the timeline button for it should never be made insensitive. This used to work until recently. I have located the source with git bisect: 9b755cf08e4abb0cc6cc52a661570c4ca6111aa7 is the first bad commit commit 9b755cf08e4abb0cc6cc52a661570c4ca6111aa7 Author: Luis de Bethencourt <luis@debethencourt.com> Date: Fri Sep 3 10:59:11 2010 +0200 ui/timeline: fixing the sensitivity of the timeline actions. :040000 040000 823c67331f4b02fc8828f20292a22a25787eb268 9c27551fab89ca48f4875eee243b4736a9e5b97b M pitivi
Created attachment 182992 [details] [review] one-liner patch Trivial patch is trivial. I could have removed lines such as "split = True" entirely, as well as the "self.split_action.set_sensitive(split)" line, but I thought that leaving those there with a comment would be better for preventing future regressions.
Fixed by a slightly modified commit 52b6f6d3a16a6b7511c983f782303d1c82f94968 Author: Jean-François Fortin Tam <nekohayo@gmail.com> Date: Wed Mar 9 10:07:35 2011 -0500 Allow splitting even when there is no selection. Fixes bug #644313.