GNOME Bugzilla – Bug 644292
[PATCH] Volume goes up to 11! Standardise the amplification amount
Last modified: 2011-03-11 16:31:20 UTC
Hi, This has been previously discussed with Lennart and I don't think it's overly controversial. The commit message I wrote says it all so I'll just paste it here: sound: Use upstream value for amplified volume. In order to standardise various separate volume UIs, upstream PulseAudio has made a new define available for the recommended maximum volume to show in UIs. This volume was chosen to be similar to the value currently employed in gvc but also be based on dB values rather than a multiple of PA_VOLUME_NORM. The 150% value previously used mapped to +10.57dB with the current cubic volume mapping. In the interests of sanity, and with a tip of the hat to Spinal Tap, we decreed that the value should be +11dB. This is approx 153% which is doesn't really change the visual look of GVC. I will also be recommending other volume controls use this new value so everyone can use the mixer they want. This one goes up to 11. :) References: https://tango.0pointer.de/pipermail/pulseaudio-discuss/2010-April/006945.html https://tango.0pointer.de/pipermail/pulseaudio-discuss/2010-April/006950.html http://en.wikipedia.org/wiki/Up_to_eleven
Created attachment 182947 [details] [review] sound: Use upstream value for amplified volume. In order to standardise various separate volume UIs, upstream PulseAudio has made a new define available for the recommended maximum volume to show in UIs. This volume was chosen to be similar to the value currently employed in gvc but also be based on dB values rather than a multiple of PA_VOLUME_NORM. The 150% value previously used mapped to +10.57dB with the current cubic volume mapping. In the interests of sanity, and with a tip of the hat to Spinal Tap, we decreed that the value should be +11dB. This is approx 153% which is doesn't really change the visual look of GVC. I will also be recommending other volume controls use this new value so everyone can use the mixer they want. This one goes up to 11. :) References: https://tango.0pointer.de/pipermail/pulseaudio-discuss/2010-April/006945.html https://tango.0pointer.de/pipermail/pulseaudio-discuss/2010-April/006950.html http://en.wikipedia.org/wiki/Up_to_eleven
FWIW, if any more gnome-media 2.x are going to be released, it would be nice to include this patch there too (it applies cleanly).
Created attachment 183155 [details] [review] sound: Use upstream value for amplified volume In order to standardise various separate volume UIs, upstream PulseAudio has made a new define available for the recommended maximum volume to show in UIs. This volume was chosen to be similar to the value currently employed in gvc but also be based on dB values rather than a multiple of PA_VOLUME_NORM. The 150% value previously used mapped to +10.57dB with the current cubic volume mapping. In the interests of sanity, and with a tip of the hat to Spinal Tap, we decreed that the value should be +11dB. This is approx 153% which is doesn't really change the visual look of GVC. I will also be recommending other volume controls use this new value so everyone can use the mixer they want. This one goes up to 11. :) References: https://tango.0pointer.de/pipermail/pulseaudio-discuss/2010-April/006945.html https://tango.0pointer.de/pipermail/pulseaudio-discuss/2010-April/006950.html http://en.wikipedia.org/wiki/Up_to_eleven
This patch should do the same thing, but also allow the Javascript code in gnome-shell to ditch its own defines (which is has to avoid depending on g-i support for PulseAudio).
Waiting on feedback for the gnome-shell code.
Seems good to me (other than the potential for unused argument warnings etc. - I presume this is needed to fit in with other stuff as it's clearly not needed as an argument per-se?)
Attachment 183155 [details] pushed as a9555f5 - sound: Use upstream value for amplified volume