GNOME Bugzilla – Bug 644255
Dash items on the overview requires a meaningful name
Last modified: 2012-03-15 19:32:18 UTC
After the changes on bug 618887, using Ctrl+Alt+Tab, you can navigate on the Dash. One of the main purposes of this feature is the accessibility support. Anyway, although you can do that, and orca reacts to the selection of those items (using see bug 640057), there is little information of each item. In other cases you could use the existing StLabel (see bug 644253), but in this case, right now are purely visual. For this reason it would be required to provide a name for them (we can fight a description later). One option would add atk_object_set_name calls on the ui code, or just create a StLabel for them, and use the code provided on bug 644253 to set the label (after all, this is one of the current accessibility advices on gtk, use gtk_widget_add_mnemonics to objects that required a name).
From bug 644253 comment 7: Also, what about Dash items? They use { showLabel: false }, so currently they have no label. Maybe you should change BaseItem to just create the StLabel anyway, but hide it? (Actually, that would make it show up in st_describe_actor()'s output too, so I think that's probably the right thing.)
(In reply to comment #1) > From bug 644253 comment 7: > > Also, what about Dash items? They use { showLabel: false }, so currently they > have no label. Maybe you should change BaseItem to just create the StLabel > anyway, but hide it? (Actually, that would make it show up in > st_describe_actor()'s output too, so I think that's probably the right thing.) Ok, I will try to look to BaseItem and check it. Anyway, before do that, what it is the meaning of "showLabel" it seems to suggest that the object has a label but it is not visible. But your comments seems to suggest that the label is not present at all.
At the moment, "showLabel: false" means that it doesn't even have a label. It's badly named...
So I think what we want here is to add StWidget:accessible-name, which overrides ClutterActor:name for the accessible name if it's set. (as discussed in bug 644253 comment 11)
(In reply to comment #4) > So I think what we want here is to add StWidget:accessible-name, which > overrides ClutterActor:name for the accessible name if it's set. > > (as discussed in bug 644253 comment 11) Aha, yes, probably in this case is the best optio, in the same fashion that the accessible-role (bug 648598), in order to being constantly asking for the accessible object and setting the name and role with atk calls.
Created attachment 207964 [details] [review] Setting proper label actor for dash elements Since last time we talked about this, label_actor property was added to StWidget, and also a label of each dash item (DashItemContainer._label). Right now it is used to show the name of the dash item if you hover over the item. So the easiest solution (in this patch) was override the default label for AppWellIcon, and use this label (the default one is the one contained on AppWellIcon, see Alt+Tab switcher for an example). This patch became somewhat big because as this patch used that label in other component I made that public (so from DashItemContainer._label to DashItemContainer.label).
Comment on attachment 207964 [details] [review] Setting proper label actor for dash elements for bonus points, commit this as two separate patches, one just doing the _label->label rename, and the other adding the label_actor override
(In reply to comment #7) > (From update of attachment 207964 [details] [review]) > for bonus points, commit this as two separate patches, one just doing the > _label->label rename, and the other adding the label_actor override I am a munchkin, so for those bonus points I have committed this as two separates patches. Closing bug.