GNOME Bugzilla – Bug 644174
Some xml files don't validate when running make check
Last modified: 2011-03-08 12:36:35 UTC
Created attachment 182802 [details] [review] Patch against git branch to fix make-up inconsistencies Running `make check` spits out some validation errors: """ Making check in help make[1]: Entering directory `/var/tmp/portage/media-video/totem-2.32.0/work/totem-2.32.0/help' xmllint --noout --noent --path C:./C --xinclude --postvalid ./C/totem.xml xmllint --noout --noent --path bg:./bg --xinclude --postvalid ./bg/totem.xml xmllint --noout --noent --path ca:./ca --xinclude --postvalid ./ca/totem.xml xmllint --noout --noent --path cs:./cs --xinclude --postvalid ./cs/totem.xml xmllint --noout --noent --path da:./da --xinclude --postvalid ./da/totem.xml xmllint --noout --noent --path de:./de --xinclude --postvalid ./de/totem.xml ./de/totem.xml:137: element releaseinfo: validity error : Element application is not declared in releaseinfo list of possible children ./de/totem.xml:334: element para: validity error : Element shortcut is not declared in para list of possible children ./de/totem.xml:334: element keycombo: validity error : Element keycombo content does not follow the DTD, expecting (keycap | keycombo | keysym | mousebutton)+, got (keycap CDATA keycap) ./de/totem.xml:343: element para: validity error : Element shortcut is not declared in para list of possible children Document ./de/totem.xml does not validate xmllint --noout --noent --path el:./el --xinclude --postvalid ./el/totem.xml xmllint --noout --noent --path en_GB:./en_GB --xinclude --postvalid ./en_GB/totem.xml xmllint --noout --noent --path es:./es --xinclude --postvalid ./es/totem.xml xmllint --noout --noent --path eu:./eu --xinclude --postvalid ./eu/totem.xml xmllint --noout --noent --path fi:./fi --xinclude --postvalid ./fi/totem.xml ./fi/totem.xml:219: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (guisubmenu CDATA guimenuitem) Document ./fi/totem.xml does not validate xmllint --noout --noent --path fr:./fr --xinclude --postvalid ./fr/totem.xml xmllint --noout --noent --path it:./it --xinclude --postvalid ./it/totem.xml ./it/totem.xml:432: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (shortcut guimenu CDATA guilabel CDATA application CDATA guilabel CDATA) ./it/totem.xml:432: element shortcut: validity error : Element shortcut content does not follow the DTD, expecting (keycap | keycombo | keysym | mousebutton)+, got (keycap CDATA) Document ./it/totem.xml does not validate xmllint --noout --noent --path ja:./ja --xinclude --postvalid ./ja/totem.xml xmllint --noout --noent --path oc:./oc --xinclude --postvalid ./oc/totem.xml xmllint --noout --noent --path pa:./pa --xinclude --postvalid ./pa/totem.xml xmllint --noout --noent --path pl:./pl --xinclude --postvalid ./pl/totem.xml ./pl/totem.xml:432: element para: validity error : Element choice is not declared in para list of possible children ./pl/totem.xml:432: element choice: validity error : No declaration for element choice ./pl/totem.xml:565: element menuchoice: validity error : Element menuchoice content does not follow the DTD, expecting (shortcut? , (guibutton | guiicon | guilabel | guimenu | guimenuitem | guisubmenu | interface)+), got (shortcut guimenu guimenuitem CDATA guibutton CDATA guilabel CDATA guilabel CDATA) Document ./pl/totem.xml does not validate xmllint --noout --noent --path pt_BR:./pt_BR --xinclude --postvalid ./pt_BR/totem.xml xmllint --noout --noent --path ru:./ru --xinclude --postvalid ./ru/totem.xml xmllint --noout --noent --path sv:./sv --xinclude --postvalid ./sv/totem.xml xmllint --noout --noent --path uk:./uk --xinclude --postvalid ./uk/totem.xml xmllint --noout --noent --path zh_CN:./zh_CN --xinclude --postvalid ./zh_CN/totem.xml xmllint --noout --noent --path zh_HK:./zh_HK --xinclude --postvalid ./zh_HK/totem.xml xmllint --noout --noent --path zh_TW:./zh_TW --xinclude --postvalid ./zh_TW/totem.xml xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-C.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-bg.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-ca.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-cs.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-da.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-de.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-el.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-en_GB.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-es.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-eu.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-fi.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-fr.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-it.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-ja.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-oc.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-pa.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-pl.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-pt_BR.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-ru.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-sv.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-uk.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-zh_CN.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-zh_HK.omf xmllint --noout --xinclude --dtdvalid 'http://scrollkeeper.sourceforge.net/dtds/scrollkeeper-omf-1.0/scrollkeeper-omf.dtd' totem-zh_TW.omf make[1]: Leaving directory `/var/tmp/portage/media-video/totem-2.32.0/work/totem-2.32.0/help' """ I attach a patch against git branch to fix invalid mark-up. As I am German native speaker, I corrected orthography and reworded one msg as well.
Comment on attachment 182802 [details] [review] Patch against git branch to fix make-up inconsistencies It looks fine, do you have git write access?
(In reply to comment #1) > (From update of attachment 182802 [details] [review]) > It looks fine, do you have git write access? No, I don't have git write access. Would you be so kind to commit it or should I apply for write access? If latter, please let me know where I get more details. But I prefer first option though.
Done: http://git.gnome.org/browse/totem/commit/?id=e3a573866 Write access would only be needed if you regularly have to commit patches.