After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 644151 - [multifilesink] Add option to create a new file after each GstForceKeyUnit event
[multifilesink] Add option to create a new file after each GstForceKeyUnit event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 607742
Blocks:
 
 
Reported: 2011-03-07 20:24 UTC by Andoni Morales
Modified: 2011-12-01 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add option to create a new file after each GstForceKeyUnit event (7.13 KB, patch)
2011-03-07 20:24 UTC, Andoni Morales 		none Details | Review
Add option to create a new file after each GstForceKeyUnit event (7.13 KB, patch)
2011-03-07 20:31 UTC, Andoni Morales 		none Details | Review
Add option to create a new file after each GstForceKeyUnit event (7.26 KB, patch)
2011-03-07 21:13 UTC, Andoni Morales 		none Details | Review
Reworked patch (13.12 KB, patch)
2011-07-17 22:01 UTC, Alessandro Decina 		none Details | Review

Description Andoni Morales 2011-03-07 20:24:22 UTC 
Created attachment 182759 [details] [review]
Add option to create a new file after each GstForceKeyUnit event

Useful for fragmented streaming, this allow segmenting on each GstForceKeyUnit event.
Comment 1 Andoni Morales 2011-03-07 20:25:41 UTC 
This patch has a mistake, let me fix it first.
Comment 2 Andoni Morales 2011-03-07 20:31:53 UTC 
Created attachment 182760 [details] [review]
Add option to create a new file after each GstForceKeyUnit event
Comment 3 Olivier Crête 2011-03-07 20:39:41 UTC 
I'm not convinced this is the right approach, you also need the muxer to cooperate.
Comment 4 Andoni Morales 2011-03-07 20:42:06 UTC 
I have submitted one for the matroska muxer for the moment.
Comment 5 David Schleef 2011-03-07 21:00:32 UTC 
I'm not convinced this is the right approach, either.  But I'm not opposed to applying the patch to multifilesink.  One detail, however: change the name of the enum to "key unit event".  "key unit" means the same thing as "key frame".  (At some point in the distant past, someone decided that "frame" was too specific and called it "unit" instead, rather than the other accepted term, "random access point".)
Comment 6 Stefan Sauer (gstreamer, gtkdoc dev) 2011-03-07 21:06:20 UTC 
I would really prefer to have a standard event in the video library first (see bug #607742). All this voodo on matching a event name is ugly, really.
Comment 7 Andoni Morales 2011-03-07 21:13:24 UTC 
Created attachment 182766 [details] [review]
Add option to create a new file after each GstForceKeyUnit event

I just want to have this property for testing purpose, I don't think either it should be used for anything else, and I think it's more useful than the keyframe one for mpegts segmenting.
Comment 8 Andoni Morales 2011-03-07 21:22:40 UTC 
(In reply to comment #6)
> I would really prefer to have a standard event in the video library first (see
> bug #607742). All this voodo on matching a event name is ugly, really.
+1 This should be a standard event
Comment 9 Alessandro Decina 2011-07-17 22:01:53 UTC 
Created attachment 192149 [details] [review]
Reworked patch

I reworked the patch to apply on git and match the new force-key-unit event API.
Comment 10 Tim-Philipp Müller 2011-12-01 13:05:59 UTC 
Guess this is fixed now:

 commit ed987552415dad43041291f0210876e39e13c8cd
 Author: Alessandro Decina <alessandro.d@gmail.com>
 Date:   Sun Jul 17 23:56:04 2011 +0200

    multifilesink: add flag to cut after a force key unit event